Add someip-statistics#2599
Merged
Merged
Conversation
kruss
force-pushed
the
add-someip-statistics-ui
branch
2 times, most recently
from
8f4fa68 to
353cefb
Compare
AmmarAbouZor
requested changes
Jun 23, 2026
AmmarAbouZor
left a comment
AmmarAbouZor
left a comment
Member
There was a problem hiding this comment.
Thanks a lot, this looks really clean and mostly fine. I've found:
- Two small correctness issues: Printing an Option instead of the direct value and columns count mismatch for the new tables. (Issues found by AI and confirmed by me, as I'm not that good as a reviewer!)
- Adjustments for dependencies declaration to keep them in the root workspace
I've also added some optional ideas in some place so you can apply any of them if you see that they fit
kruss
force-pushed
the
add-someip-statistics-ui
branch
from
353cefb to
aad4ffe
Compare
kruss
force-pushed
the
add-someip-statistics-ui
branch
from
aad4ffe to
53814a8
Compare
AmmarAbouZor
approved these changes
Jun 24, 2026
AmmarAbouZor
left a comment
AmmarAbouZor
left a comment
Member
There was a problem hiding this comment.
This looks great! Thanks 🙏
Let's merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds someip-statistics to the ui and let user apply corresponding filters on parsing.