Skip to content

fix(test-benchmark): address EIP-8037 spec compatibility issues#3026

Open
LouisTsai-Csie wants to merge 8 commits into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:refactor-bench-for-8037-spec
Open

fix(test-benchmark): address EIP-8037 spec compatibility issues#3026
LouisTsai-Csie wants to merge 8 commits into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:refactor-bench-for-8037-spec

Conversation

@LouisTsai-Csie

@LouisTsai-Csie LouisTsai-Csie commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

Refactor tests/benchmark/compute for Amsterdam spec: account for EIP-8037 (state-gas reservoir) and EIP-7778 (calldata repricing).

Key changes:

  • Split gas accounting into regular-gas and state-gas bounds
  • Update IteratingBytecode, CustomSizedContractFactory, and gas measurement
  • Add skip guards for scenarios exceeding --gas-benchmark-values
  • Point CI to Amsterdam; use bal-devnet-7 geth reference

🔗 Related Issues or PRs

Issue #2913

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie force-pushed the refactor-bench-for-8037-spec branch from 28cc994 to 2d3ff99 Compare June 19, 2026 12:14
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (3f888bc) to head (1582cc3).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3026   +/-   ##
================================================
  Coverage            93.22%   93.22%           
================================================
  Files                  624      624           
  Lines                36926    36926           
  Branches              3377     3377           
================================================
  Hits                 34424    34424           
  Misses                1708     1708           
  Partials               794      794           
Flag Coverage Δ
unittests 93.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LouisTsai-Csie LouisTsai-Csie force-pushed the refactor-bench-for-8037-spec branch from 2d3ff99 to 9397580 Compare June 25, 2026 08:16
@LouisTsai-Csie LouisTsai-Csie added A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-refactor Category: refactor labels Jun 25, 2026
@LouisTsai-Csie LouisTsai-Csie force-pushed the refactor-bench-for-8037-spec branch from 9397580 to 9a3ad5d Compare June 29, 2026 05:42
@LouisTsai-Csie LouisTsai-Csie force-pushed the refactor-bench-for-8037-spec branch from 65e4911 to 1582cc3 Compare June 30, 2026 06:07
@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review June 30, 2026 06:12
Comment thread .github/configs/evm.yaml
impl: geth
repo: ethereum/go-ethereum
ref: master No newline at end of file
ref: bal-devnet-7 No newline at end of file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the fork from Osaka to Amsterdam per bal-devnet-7 spec. Note: forks/amsterdam doesn't fully match bal-devnet-7, which isn't ideal. If that's a problem, I can verify locally instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-refactor Category: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant