Move priority-fee check to validate_transaction#3056
Open
jevinjojo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Moves the stateless check
tx.max_fee_per_gas < tx.max_priority_fee_per_gasfrom
check_transaction(stateful layer) tovalidate_transaction(stateless layer) in the amsterdam fork.
The check only compares two fields on the transaction and needs no block
context, so it belongs in the stateless layer. The remaining checks in that
block use
block_env.base_fee_per_gasand correctly stay incheck_transaction.In
validate_transactionthe check is guarded by anisinstance(tx, FeeMarketCapableTransaction)check so legacy transactions areunaffected. The now-unused import is removed from
fork.py🔗 Related Issues
tx.max_fee_per_gas < tx.max_priority_fee_per_gasbe moved tovalidate_transaction? #2976✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture