chore(tests-benchmark, ci): mark test_keccak_max_permutations as slow#3058
Closed
danceratopz wants to merge 1 commit into
Closed
chore(tests-benchmark, ci): mark test_keccak_max_permutations as slow#3058danceratopz wants to merge 1 commit into
danceratopz wants to merge 1 commit into
Conversation
`test_keccak_max_permutations` dominates the `bench-gas` smoke check: It fills in ~465s per format, while the next slowest benchmark is ~12s, because it searches for the input size that maximizes keccak permutations per block and then fills a maximal block. Marking it `slow` excludes it from the smoke check (`just bench-gas` runs `-m "not slow"`), matching `test_blockhash` and `test_bls12_g2_msm`. The release benchmark matrix (`.github/configs/feature.yaml`) does not filter `slow`, so the test still ships in the released fixtures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3058 +/- ##
================================================
Coverage 93.22% 93.22%
================================================
Files 624 624
Lines 36926 36926
Branches 3377 3377
================================================
Hits 34424 34424
Misses 1708 1708
Partials 794 794
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jun 29, 2026
Member
Author
|
This shouldn't be required with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
test_keccak_max_permutationsis by far the most expensive test in thebench-gassmoke check: It fills in ~465s per format, while the next slowest benchmark fills in ~12s. The test searches for the input size that maximizes keccak permutations per block and then fills a maximal block, and that work is repeated per fixture format.Marking it
@pytest.mark.slowexcludes it from the smoke check (just bench-gasand the benchmark sanity checks run-m "not slow"), consistent with the existing slow benchmarkstest_blockhashandtest_bls12_g2_msm. The release benchmark matrix (.github/configs/feature.yaml) does not filterslow, so the test still ships in the released fixtures.🔗 Related Issues or PRs
Addresses #2673. Complements #3057 (fill only the
blockchain_testformat inbench-gas): Even with that format reduction the test still fills once at ~465s and sets the smoke check's floor, and this marker removes it.✅ Checklist
just statictype(scope):.