🐛 app: misc fixes & improvements#1100
Conversation
🦋 Changeset detectedLatest commit: 42a3df9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRemoves the legacy ChangesStyledButton Migration and Visual Fixes
Shared RefreshControl and Pull-to-Refresh Refactoring
Installment APR Calculation and Deployed-Chain Detection
E2E Redbox and LogBox Suppression
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the button components by migrating from legacy Button and ActionButton to StyledButton across the application, while deleting the obsolete button files. Additionally, it fixes SVG positioning by adding position="relative" to several wrapper views, disables Redbox and Logbox for E2E testing, and corrects the installment APR calculation in useInstallmentRates using floatingAssetsAverage. The review feedback recommends removing redundant color props from icons wrapped in Button.Icon within the payment components, as StyledButton automatically handles icon coloring.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: aa377fe4-c360-4e69-861f-8aee2e4300bd
📒 Files selected for processing (46)
.changeset/full-towns-glow.md.changeset/plain-bags-rhyme.md.changeset/rare-parks-arrive.md.changeset/warm-pandas-fold.mdsrc/components/activity/Empty.tsxsrc/components/activity/details/ActivityDetails.tsxsrc/components/add-funds/Bridge.tsxsrc/components/add-funds/Ramp.tsxsrc/components/add-funds/SupportedAssetsSheet.tsxsrc/components/auth/Passkeys.tsxsrc/components/auth/Success.tsxsrc/components/card/CardDisclaimer.tsxsrc/components/card/CardFreezeSheet.tsxsrc/components/card/CardPIN.tsxsrc/components/card/VerificationFailure.tsxsrc/components/defi/AboutDefiSheet.tsxsrc/components/getting-started/GettingStarted.tsxsrc/components/home/CollateralAssetsSheet.tsxsrc/components/home/CreditLimitSheet.tsxsrc/components/home/ExternalAssetsSheet.tsxsrc/components/home/PayModeSheet.tsxsrc/components/home/SpendingLimitSheet.tsxsrc/components/home/UnsupportedNetworksSheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/components/home/card-upgrade/Intro.tsxsrc/components/home/card-upgrade/UpgradeAccount.tsxsrc/components/home/card-upgrade/VerifyIdentity.tsxsrc/components/pay/Empty.tsxsrc/components/pay/Pay.tsxsrc/components/pay/PaymentSheet.tsxsrc/components/pay/RolloverIntroSheet.tsxsrc/components/send-funds/Asset.tsxsrc/components/shared/ActionButton.tsxsrc/components/shared/AddressDialog.tsxsrc/components/shared/AmountSelector.tsxsrc/components/shared/Button.tsxsrc/components/shared/CopyAddressSheet.tsxsrc/components/shared/Error.tsxsrc/components/shared/ErrorDialog.tsxsrc/components/shared/StyledButton.tsxsrc/components/swaps/Success.tsxsrc/components/swaps/Swaps.tsxsrc/index.jssrc/utils/redbox.tssrc/utils/useInstallmentRates.tssrc/utils/useMarkets.ts
💤 Files with no reviewable changes (2)
- src/components/shared/Button.tsx
- src/components/shared/ActionButton.tsx
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 76.02% 76.00% -0.02%
==========================================
Files 245 247 +2
Lines 12044 11974 -70
Branches 4284 4240 -44
==========================================
- Hits 9156 9101 -55
+ Misses 2572 2556 -16
- Partials 316 317 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dieguezguille
force-pushed
the
fixes
branch
2 times, most recently
from
9a464e6 to
c665726
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 424d3949-4911-4933-a623-b63161fa937c
📒 Files selected for processing (42)
.changeset/plain-bags-rhyme.md.changeset/warm-pandas-fold.mdsrc/components/activity/Empty.tsxsrc/components/activity/details/ActivityDetails.tsxsrc/components/add-funds/Bridge.tsxsrc/components/add-funds/Ramp.tsxsrc/components/add-funds/SupportedAssetsSheet.tsxsrc/components/auth/Passkeys.tsxsrc/components/auth/Success.tsxsrc/components/card/CardDisclaimer.tsxsrc/components/card/CardFreezeSheet.tsxsrc/components/card/CardPIN.tsxsrc/components/card/VerificationFailure.tsxsrc/components/defi/AboutDefiSheet.tsxsrc/components/getting-started/GettingStarted.tsxsrc/components/home/CollateralAssetsSheet.tsxsrc/components/home/CreditLimitSheet.tsxsrc/components/home/ExternalAssetsSheet.tsxsrc/components/home/PayModeSheet.tsxsrc/components/home/SpendingLimitSheet.tsxsrc/components/home/UnsupportedNetworksSheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/components/home/card-upgrade/Intro.tsxsrc/components/home/card-upgrade/UpgradeAccount.tsxsrc/components/home/card-upgrade/VerifyIdentity.tsxsrc/components/pay/Empty.tsxsrc/components/pay/Pay.tsxsrc/components/pay/PaymentSheet.tsxsrc/components/pay/RolloverIntroSheet.tsxsrc/components/send-funds/Asset.tsxsrc/components/shared/ActionButton.tsxsrc/components/shared/AddressDialog.tsxsrc/components/shared/AmountSelector.tsxsrc/components/shared/Button.tsxsrc/components/shared/CopyAddressSheet.tsxsrc/components/shared/Error.tsxsrc/components/shared/ErrorDialog.tsxsrc/components/shared/StyledButton.tsxsrc/components/swaps/Success.tsxsrc/components/swaps/Swaps.tsxsrc/index.jssrc/utils/redbox.ts
💤 Files with no reviewable changes (2)
- src/components/shared/ActionButton.tsx
- src/components/shared/Button.tsx
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7f9a7645e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42d2a72830
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
closes #446
Summary by CodeRabbit