🚸 app: improve card creation timeout ux#1105
Conversation
🦋 Changeset detectedLatest commit: b855fb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a delayed setup modal for card creation, wires it into card generation and activation flows, records support-contact state in React Query, and adds matching translations plus release metadata. ChangesCard Setup Timeout UX
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the card creation timeout user experience by introducing a SetupDelaySheet component that prompts users to contact support or keep waiting when setup takes longer than expected. Feedback highlights a critical issue in Card.tsx where refetchCard() resolves instead of rejecting on error, causing standard errors to incorrectly trigger the delay signal. Additionally, it is recommended to refactor SetupDelaySheet.tsx to handle the support message trigger via a useEffect hook in the parent component rather than relying on the unmount lifecycle of a separate helper component, which can be removed to simplify the code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 32e6c724-042e-4cea-b2f2-5f9264de488f
📒 Files selected for processing (7)
.changeset/heavy-worms-cheer.mdsrc/components/card/Card.tsxsrc/components/card/SetupDelaySheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/queryClient.ts
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## fixes #1105 +/- ##
==========================================
- Coverage 76.00% 75.89% -0.12%
==========================================
Files 247 248 +1
Lines 11974 12020 +46
Branches 4240 4259 +19
==========================================
+ Hits 9101 9122 +21
- Misses 2556 2581 +25
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 02848a35-bd5f-41bc-a7ac-235407d3f409
📒 Files selected for processing (7)
.changeset/heavy-worms-cheer.mdsrc/components/card/Card.tsxsrc/components/card/SetupDelaySheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/queryClient.ts
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4dd8c961-0b53-4d8b-8501-49293c62e5be
📒 Files selected for processing (7)
.changeset/heavy-worms-cheer.mdsrc/components/card/Card.tsxsrc/components/card/SetupDelaySheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/queryClient.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f4a343f81
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bc9a4ec0e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| refetchCard() | ||
| .then(({ data, error }) => { | ||
| if (error) reportError(error); | ||
| else if (data) queryClient.setQueryData(["card-details-open"], true); |
There was a problem hiding this comment.
When a card-creation request times out after the server has already inserted the card, this new tap path can find the card with refetchCard(), but it only opens the details sheet. The original create-card mutation is still pending and retries every APIError (for example, the next POST returns already created), so isGeneratingCard stays true and the card keeps showing the loading/delay UX even though the card now exists. Treat this branch as a completed activation or stop the retry instead of only opening details.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 161326f3-f02d-440b-b0cf-90ed3cf1a721
📒 Files selected for processing (7)
.changeset/heavy-worms-cheer.mdsrc/components/card/Card.tsxsrc/components/card/SetupDelaySheet.tsxsrc/components/home/card-upgrade/ActivateCard.tsxsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/queryClient.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00c45eb31e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| </Text> | ||
| )} | ||
| </YStack> | ||
| <SetupDelaySheet failureCount={activateFailures} pending={isActivating} submittedAt={activateSubmittedAt} /> |
There was a problem hiding this comment.
In the upgrade activation flow, once the delay sheet is dismissed with “Keep waiting”, SetupDelaySheet records the current ${submittedAt}:0 prompt and will not open again until either submittedAt or openSignal changes. This screen never passes an openSignal, and the activation button is disabled while isActivating, so a user stuck in the same long-running upgrade cannot get back to the support action after dismissing the first prompt; the card screen avoids this by incrementing openSignal on card taps.
Useful? React with 👍 / 👎.
1 participant
closes #1098
Summary by CodeRabbit
Summary
New Features
Bug Fixes
Localization
Release