Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
left a comment
There was a problem hiding this comment.
I need to dig deeper into the commented out tests. It may take me a day or two, so please be patient. Thanks a lot for helping!
|
@Narkunan I'm sorry, but this change is getting a bit harder. I hope you can understand what I'm asking for:
Well, yes, sorry again. I haven't seen all this when I classified the issue as "good first issue". That is a lot of exceptional stuff to do... |
mk-mxp
left a comment
There was a problem hiding this comment.
I hope the new GitHub pull request feature for commenting on unchanged lines works as expected 😃
|
@mk-mxp I hope I addressed everything. Please check now 😊 |
mk-mxp
left a comment
There was a problem hiding this comment.
Thanks again for the great work!
Fix issue #922