Skip to content

Add video playback progress overlay - #1795

Closed
kanihal wants to merge 3 commits into
extesy:masterfrom
kanihal:codex/playback-progress-listener-cleanup
Closed

Add video playback progress overlay#1795
kanihal wants to merge 3 commits into
extesy:masterfrom
kanihal:codex/playback-progress-listener-cleanup

Conversation

@kanihal

@kanihal kanihal commented Jul 14, 2026

Copy link
Copy Markdown

Summary

  • Add a bottom overlay progress bar for zoomed videos
  • Show elapsed and total playback time when media duration is available
  • Hide the progress overlay for streams/media without a finite duration
  • Remove previously registered playback progress listeners before attaching replacements

Review follow-up

This supersedes #1790 and addresses the duplicate-listener and stale-closure issue raised in the review thread.

Validation

  • node --check js/hoverzoom.js
  • git diff --check origin/master...HEAD
  • Targeted mocked-video regression check: calling addPlaybackProgress(video) twice leaves one current listener for each playback event and removes the stale callbacks

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a custom playback progress bar overlay for videos in HoverZoom, including CSS styling, time formatting, and event-driven progress updates. The reviewer recommends hiding this custom progress bar when the viewer is locked to avoid visual overlap with the browser's native video controls.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread js/hoverzoom.js
@kanihal

kanihal commented Jul 14, 2026

Copy link
Copy Markdown
Author

Closing this replacement PR as requested. Both review fixes have been moved to the original PR #1790.

@kanihal kanihal closed this Jul 14, 2026
@kanihal
kanihal deleted the codex/playback-progress-listener-cleanup branch July 14, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant