Fix duplicate $feature_opts in run.sh LeafNodeRank invocation#754
Open
excelle08 wants to merge 1 commit into
Open
Fix duplicate $feature_opts in run.sh LeafNodeRank invocation#754excelle08 wants to merge 1 commit into
excelle08 wants to merge 1 commit into
Conversation
Summary: run.sh line 866 and 870 both expand $feature_opts, causing LeafNodeRank to receive `--feature_extractors` twice. gengetopt rejects any bare flag given more than once and LeafNodeRank exits immediately during startup. run.sh's driver then times out waiting for LeafNodeRank on port 21212, and the shell's downstream `bc`-based aggregation trips a divide-by-zero on empty results (`Runtime error (func=(main), adr=18): Divide by zero`). Net effect: since the t43 c7 default-baking landed on 2026-07-03, every `feedsim_dlrm` run has silently produced null metrics — the JSON output has `"metrics": null` and no `final_achieved_qps` is emitted. Remove the duplicate expansion at line 870. Verified locally that LeafNodeRank standalone with a single `--feature_extractors` starts and reaches port-listening state. Differential Revision: D111533997
meta-cla
Bot
added
the
CLA Signed
|
@excelle08 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111533997. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 11, 2026
Summary: Pull Request resolved: #754 run.sh line 866 and 870 both expand $feature_opts, causing LeafNodeRank to receive `--feature_extractors` twice. gengetopt rejects any bare flag given more than once and LeafNodeRank exits immediately during startup. run.sh's driver then times out waiting for LeafNodeRank on port 21212, and the shell's downstream `bc`-based aggregation trips a divide-by-zero on empty results (`Runtime error (func=(main), adr=18): Divide by zero`). Net effect: since the t43 c7 default-baking landed on 2026-07-03, every `feedsim_dlrm` run has silently produced null metrics — the JSON output has `"metrics": null` and no `final_achieved_qps` is emitted. Remove the duplicate expansion at line 870. Verified locally that LeafNodeRank standalone with a single `--feature_extractors` starts and reaches port-listening state. ___ Reviewed By: charles-typ Differential Revision: D111533997 fbshipit-source-id: 940c0165991a54628ba2badc32d59bb2faa8d05c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
run.sh line 866 and 870 both expand $feature_opts, causing LeafNodeRank to receive
--feature_extractorstwice. gengetopt rejects any bare flag given more than once and LeafNodeRank exits immediately during startup. run.sh's driver then times out waiting for LeafNodeRank on port 21212, and the shell's downstreambc-based aggregation trips a divide-by-zero on empty results (Runtime error (func=(main), adr=18): Divide by zero). Net effect: since the t43 c7 default-baking landed on 2026-07-03, everyfeedsim_dlrmrun has silently produced null metrics — the JSON output has"metrics": nulland nofinal_achieved_qpsis emitted.Remove the duplicate expansion at line 870. Verified locally that LeafNodeRank standalone with a single
--feature_extractorsstarts and reaches port-listening state.Differential Revision: D111533997