logo: update NurOS logo and colors#2366
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The pull request introduces the new Braille-based ASCII art for the NurOS logo, but contains a critical formatting error that will prevent correct terminal rendering. Specifically, the ANSI 24-bit color sequences in n.inc are missing the mandatory 'm' termination character, which typically results in corrupted terminal output.
Furthermore, there is a discrepancy between the defined color palette and the ASCII template. Although four specific RGB colors were added to create a gradient effect, the nuros.txt file only utilizes the first color placeholder ($1) for every line. This leaves three-quarters of the defined palette unused and prevents the intended gradient from appearing. These issues should be addressed before merging to ensure the logo renders as intended.
About this PR
- The current implementation of the ASCII art in 'nuros.txt' only utilizes the '$1' placeholder. This effectively ignores the colors '$2', '$3', and '$4' defined in the 'n.inc' palette, resulting in a monochromatic logo rather than the intended gradient.
Test suggestions
- NurOS logo renders using the new Braille character set
- Logo leverages all 4 colors in the defined RGB palette
- Key color is correctly assigned to the light blue RGB value (13;125;250)
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Logo leverages all 4 colors in the defined RGB palette
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Summary
Update NurOS logo with the official braille ASCII art and correct RGB colors.
Related issue
Closes #2365
Changes
nuros.txtwith the official braille ASCII art provided in the issuen.incwith the correct RGB values (41;19;182,31;59;205,18;95;225,13;125;250)Screenshots
Checklist