Skip to content

logo: update NurOS logo and colors#2366

Open
cicada0961 wants to merge 2 commits into
fastfetch-cli:devfrom
cicada0961:logo/nuros-update
Open

logo: update NurOS logo and colors#2366
cicada0961 wants to merge 2 commits into
fastfetch-cli:devfrom
cicada0961:logo/nuros-update

Conversation

@cicada0961
Copy link
Copy Markdown

@cicada0961 cicada0961 commented Jun 2, 2026

Summary

Update NurOS logo with the official braille ASCII art and correct RGB colors.

Related issue

Closes #2365

Changes

  • Replace nuros.txt with the official braille ASCII art provided in the issue
  • Update colors in n.inc with the correct RGB values (41;19;182, 31;59;205, 18;95;225, 13;125;250)

Screenshots

Capture d’écran 2026-06-02 à 19 00 23

Checklist

  • I have tested my changes locally.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Jun 2, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The pull request introduces the new Braille-based ASCII art for the NurOS logo, but contains a critical formatting error that will prevent correct terminal rendering. Specifically, the ANSI 24-bit color sequences in n.inc are missing the mandatory 'm' termination character, which typically results in corrupted terminal output.

Furthermore, there is a discrepancy between the defined color palette and the ASCII template. Although four specific RGB colors were added to create a gradient effect, the nuros.txt file only utilizes the first color placeholder ($1) for every line. This leaves three-quarters of the defined palette unused and prevents the intended gradient from appearing. These issues should be addressed before merging to ensure the logo renders as intended.

About this PR

  • The current implementation of the ASCII art in 'nuros.txt' only utilizes the '$1' placeholder. This effectively ignores the colors '$2', '$3', and '$4' defined in the 'n.inc' palette, resulting in a monochromatic logo rather than the intended gradient.

Test suggestions

  • NurOS logo renders using the new Braille character set
  • Logo leverages all 4 colors in the defined RGB palette
  • Key color is correctly assigned to the light blue RGB value (13;125;250)
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Logo leverages all 4 colors in the defined RGB palette

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread src/logo/ascii/n.inc
Comment thread src/logo/ascii/n/nuros.txt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LOGO] NurOS

1 participant