[rpm] check if print-rpath outputs $ORIGIN and not if the output path has /home - #170
Closed
resucutie wants to merge 1 commit into
Closed
[rpm] check if print-rpath outputs $ORIGIN and not if the output path has /home#170resucutie wants to merge 1 commit into
resucutie wants to merge 1 commit into
Conversation
lijy91
force-pushed
the
main
branch
2 times, most recently
from
April 2, 2024 00:55
82b33ec to
3c03a4a
Compare
Contributor
|
I don't know how to test it |
Author
|
you can test by creating a project in a path outside of /home, on my case on an external device to load on /mnt, and then trying to run flutter_distributor |
lijy91
force-pushed
the
main
branch
4 times, most recently
from
June 23, 2024 02:34
d893621 to
c1babe8
Compare
Contributor
|
Thank you for the contribution. I am closing this PR because it has been superseded by #310, which is now merged and includes tested handling for absolute and mixed RPATH entries. The original problem is covered by the implementation on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to check if the path equals to $ORIGIN, and not /home, as projects can be created outside of the /home folder
NOTE: THIS PULL REQUEST WASN'T TESTED AS I WASN'T ABLE TO TEST ON MY SYSTEM