fix(rpm): enable post-install scripts and fix post-uninstall logic - #307
Merged
Conversation
eximius313
force-pushed
the
fix/rpm-post-scripts
branch
from
December 27, 2025 22:39
28c9fdc to
03cdc8d
Compare
eximius313
force-pushed
the
fix/rpm-post-scripts
branch
from
July 19, 2026 15:06
03cdc8d to
2e31ffa
Compare
Contributor
Author
|
@lijy91 - I wanted to follow up on this PR. Could you let me know if there's anything blocking it from being merged? If you'd prefer a different approach or there are changes you'd like to see, I'm happy to update the PR accordingly. I'd appreciate any feedback when you have a chance. Thanks! |
- Added support for `%post` scripts in RPM spec generation (previously missing). - Fixed `%postun` implementation which was ignoring configuration fields due to hardcoded values. - Aligned configuration API with Debian packager by supporting `postinstall_scripts` and `postuninstall_scripts` lists. - Added backward compatibility for legacy string key (`postun`).
lijy91
force-pushed
the
fix/rpm-post-scripts
branch
from
July 21, 2026 06:15
2e31ffa to
cc33b0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306
%postscripts in RPM spec generation (previously missing).%postunimplementation which was ignoring configuration fields due to hardcoded values.postinstall_scriptsandpostuninstall_scriptslists.postun).