Rename MeanMedianImputer to MeanImputer - #975
Merged
Merged
Conversation
Keep MeanMedianImputer as a FutureWarning wrapper until 2.1.0, update tests for both names, and refresh docs/API pages (including file renames). Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
Sphinx -W failed with undefined label mean_median_imputer after the user-guide ref was renamed with the page. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Hi @ojassharma7, I saw that you're already working on MeanImputer. I'll work on the other two classes, as @solegalli suggested. |
Contributor
|
As requested, I've closed PR #972 and split the changes into separate PRs.
Thanks for the guidance! |
Collaborator
|
Thanks a lot @ojassharma7 ! Great contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MeanMedianImputer→MeanImputer(issue rename imputer classes #971), keeping a deprecatedMeanMedianImputeralias that raisesFutureWarninguntil 2.1.0.MeanMedianImputer.rst→MeanImputer.rst(API + user guide), plus call sites in quickstart/other guides.Why a focused PR
Per @solegalli on #973: split the rename into one PR per class and start with MeanMedianImputer. The other two renames (
AddMissingIndicator,ArbitraryNumberImputer) will follow separately to avoid overlap with #972.Related
Test plan
MeanMedianImputer()warns and still works