Skip to content

Changes for high contrast mode#377

Open
pratikgolchha wants to merge 9 commits into
fgnass:masterfrom
pratikgolchha:master
Open

Changes for high contrast mode#377
pratikgolchha wants to merge 9 commits into
fgnass:masterfrom
pratikgolchha:master

Conversation

@pratikgolchha

Copy link
Copy Markdown

Changes for high contrast mode. Spinner is not visible in high contrast mode

@pratikgolchha

Copy link
Copy Markdown
Author

@fgnass @theodorejb Please review this PR

@theodorejb

Copy link
Copy Markdown
Collaborator

@pratikgolchha Have you tested this? The property value needs to be a string. Also, the transparent border seems to cause an issue where setting line length to 0 and corners to 1 no longer results in perfectly round circles.

@pratikgolchha

Copy link
Copy Markdown
Author

@theodorejb I have removed the border and applied it only in high contrast mode.

@theodorejb

Copy link
Copy Markdown
Collaborator

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-ms-high-contrast has the following warning:

This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user.

Also, were you able to get it working? For me the style applied when not in the media query, but when in the media query it didn't apply even when high contrast mode was active (tested in IE 11 and Edge 18).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants