fix issue in the new RC unit tests#1205
Open
rathovarun1032 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ServerTemplateImpl constructor to throw an IllegalArgumentException when JSON parsing fails, replacing a simple stack trace print. Correspondingly, the unit tests have been updated to verify that this exception is thrown during the template building phase and that it contains the correct cause and message. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(rc): Throw IllegalArgumentException for invalid template JSON
The
ServerTemplateImplconstructor was catching template parsingexceptions and only printing the stack trace to stderr. This resulted
in noisy console output during unit tests, even when the tests passed.
This change updates the constructor to throw an
IllegalArgumentExceptionwhen a provided
cachedTemplatefails to parse.Updated
testEvaluateWithInvalidCacheValueThrowsExceptionto assertthis new behavior.