You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a considered a breaking change and should not be merged until the next major release.
Upgrade from Node 20 as the minimum version to Node 24.
Node 24 is the current "active" version of Node and was released May 2025, so it is a reasonable version to require.
This change upgrades
Required Node version in the SDK (through the "engines" fields in package.jsons)
Node version installed in CI workflows
Node 24 adds the ability to run TypeScript natively in Node, but this is done by just stripping types, which a number of our TS files aren't set up to work with, and it would require a good amount of refactoring, which isn't in scope at this time. We had to add the --no-strip-types options to the test scripts that don't work with this.
Node 24.12.0 is the earliest version that allows NODE_OPTIONS="--no-strip-types" (so that's what is in the engines fields, to be conservative for end users) and Node 24.19.0 is the most recent version of 24 at this time (so that's what's in the CI workflows, to keep them as current as possible).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the tested Node.js version to 24.19.0, upgrades @types/node to 24.1.0 across multiple packages, and adds NODE_OPTIONS='--no-strip-types' to several test scripts. Feedback on the changes points out that setting environment variables directly before commands is POSIX-specific and will fail on Windows, suggesting the use of cross-env to ensure cross-platform compatibility.
A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v17.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a considered a breaking change and should not be merged until the next major release.
Upgrade from Node 20 as the minimum version to Node 24.
Node 24 is the current "active" version of Node and was released May 2025, so it is a reasonable version to require.
This change upgrades
Node 24 adds the ability to run TypeScript natively in Node, but this is done by just stripping types, which a number of our TS files aren't set up to work with, and it would require a good amount of refactoring, which isn't in scope at this time. We had to add the
--no-strip-typesoptions to the test scripts that don't work with this.Node 24.12.0 is the earliest version that allows NODE_OPTIONS="--no-strip-types" (so that's what is in the engines fields, to be conservative for end users) and Node 24.19.0 is the most recent version of 24 at this time (so that's what's in the CI workflows, to keep them as current as possible).