Skip to content

build!: Update minimum required Node version to 24 - #10314

Draft
hsubox76 wants to merge 8 commits into
mainfrom
ch-node24
Draft

build!: Update minimum required Node version to 24#10314
hsubox76 wants to merge 8 commits into
mainfrom
ch-node24

Conversation

@hsubox76

@hsubox76 hsubox76 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This is a considered a breaking change and should not be merged until the next major release.

Upgrade from Node 20 as the minimum version to Node 24.

Node 24 is the current "active" version of Node and was released May 2025, so it is a reasonable version to require.

This change upgrades

  • Required Node version in the SDK (through the "engines" fields in package.jsons)
  • Node version installed in CI workflows

Node 24 adds the ability to run TypeScript natively in Node, but this is done by just stripping types, which a number of our TS files aren't set up to work with, and it would require a good amount of refactoring, which isn't in scope at this time. We had to add the --no-strip-types options to the test scripts that don't work with this.

Node 24.12.0 is the earliest version that allows NODE_OPTIONS="--no-strip-types" (so that's what is in the engines fields, to be conservative for end users) and Node 24.19.0 is the most recent version of 24 at this time (so that's what's in the CI workflows, to keep them as current as possible).

@changeset-bot

changeset-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 55dd6de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 changed the title build: Update minimum required Node version to 24 build!: Update minimum required Node version to 24 Aug 17, 2026
@wiz-9635d3485b

wiz-9635d3485b Bot commented Aug 17, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 7 High 5 Medium
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 7 High 5 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tested Node.js version to 24.19.0, upgrades @types/node to 24.1.0 across multiple packages, and adds NODE_OPTIONS='--no-strip-types' to several test scripts. Feedback on the changes points out that setting environment variables directly before commands is POSIX-specific and will fail on Windows, suggesting the use of cross-env to ensure cross-platform compatibility.

Comment thread packages/auth/package.json
Comment thread packages/firestore-compat/package.json
Comment thread packages/firestore/package.json
@github-actions

Copy link
Copy Markdown
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant