Decimal128 Increment spec test - #10317
Conversation
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for verifying server-side transform results in spec tests, specifically adding a test case for Decimal128 increment precision recovery upon server acknowledgment. It updates the spec builder and test runner to accept and propagate transformResults during write acknowledgments. The review feedback highlights a potential issue where hardcoding mutationResults to a single-element array will cause assertion failures for multi-mutation batches, and provides a code suggestion to dynamically construct the results array based on the mutation count.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements a toJSON method for Decimal128Value to support JSON serialization. It also updates the spec test runner and builder to support transformResults in write acknowledgments, and adds unit tests verifying that Decimal128 increment operations correctly recover precision upon receiving server acknowledgments. I have no feedback to provide as there are no review comments.
Added spec test for
Decimal128increment, verifying thatincrementAdded
transformOperationstowriteAckto allow transform operations to be part of the ack.