Update framework readmes for tracing - #10327
Conversation
|
There was a problem hiding this comment.
Code Review
This pull request updates the integration documentation for both Angular and Next.js to include instructions on tracking route changes with Firebase Crashlytics. Specifically, it adds documentation for using setupCrashlyticsRoutes in Angular and <CrashlyticsRoutes> in Next.js. A review comment points out that FirebaseApp is used as a type annotation in the Angular code snippet but is not imported, which would cause compilation errors when copied by users.
| import { | ||
| ApplicationConfig, | ||
| DestroyRef, | ||
| ErrorHandler, | ||
| inject, | ||
| provideEnvironmentInitializer | ||
| } from '@angular/core'; | ||
| import { provideRouter, Router } from '@angular/router'; | ||
| import { | ||
| FirebaseErrorHandler, | ||
| setupCrashlyticsRoutes | ||
| } from '@firebase/crashlytics/angular'; | ||
| import { FIREBASE_APP, provideFirebaseApp } from './firebase.config'; | ||
| import { routes } from './app.routes'; |
There was a problem hiding this comment.
The code snippet uses FirebaseApp as a type annotation in the useFactory function on line 101, but FirebaseApp is not imported. To prevent compilation errors when users copy and paste this snippet, please add the import for FirebaseApp from @firebase/app.
| import { | |
| ApplicationConfig, | |
| DestroyRef, | |
| ErrorHandler, | |
| inject, | |
| provideEnvironmentInitializer | |
| } from '@angular/core'; | |
| import { provideRouter, Router } from '@angular/router'; | |
| import { | |
| FirebaseErrorHandler, | |
| setupCrashlyticsRoutes | |
| } from '@firebase/crashlytics/angular'; | |
| import { FIREBASE_APP, provideFirebaseApp } from './firebase.config'; | |
| import { routes } from './app.routes'; | |
| import { | |
| ApplicationConfig, | |
| DestroyRef, | |
| ErrorHandler, | |
| inject, | |
| provideEnvironmentInitializer | |
| } from '@angular/core'; | |
| import { provideRouter, Router } from '@angular/router'; | |
| import { FirebaseApp } from '@firebase/app'; | |
| import { | |
| FirebaseErrorHandler, | |
| setupCrashlyticsRoutes | |
| } from '@firebase/crashlytics/angular'; | |
| import { FIREBASE_APP, provideFirebaseApp } from './firebase.config'; | |
| import { routes } from './app.routes'; |
No description provided.