Skip to content

Update framework readmes for tracing - #10327

Open
MaesterChestnut wants to merge 1 commit into
crashlytics-traces2from
tracingExampleDocsUpdate
Open

Update framework readmes for tracing#10327
MaesterChestnut wants to merge 1 commit into
crashlytics-traces2from
tracingExampleDocsUpdate

Conversation

@MaesterChestnut

Copy link
Copy Markdown

No description provided.

@MaesterChestnut
MaesterChestnut requested a review from a team as a code owner August 25, 2026 17:55
@changeset-bot

changeset-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4a0eb74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration documentation for both Angular and Next.js to include instructions on tracking route changes with Firebase Crashlytics. Specifically, it adds documentation for using setupCrashlyticsRoutes in Angular and <CrashlyticsRoutes> in Next.js. A review comment points out that FirebaseApp is used as a type annotation in the Angular code snippet but is not imported, which would cause compilation errors when copied by users.

Comment on lines +75 to +88
import {
ApplicationConfig,
DestroyRef,
ErrorHandler,
inject,
provideEnvironmentInitializer
} from '@angular/core';
import { provideRouter, Router } from '@angular/router';
import {
FirebaseErrorHandler,
setupCrashlyticsRoutes
} from '@firebase/crashlytics/angular';
import { FIREBASE_APP, provideFirebaseApp } from './firebase.config';
import { routes } from './app.routes';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The code snippet uses FirebaseApp as a type annotation in the useFactory function on line 101, but FirebaseApp is not imported. To prevent compilation errors when users copy and paste this snippet, please add the import for FirebaseApp from @firebase/app.

Suggested change
import {
ApplicationConfig,
DestroyRef,
ErrorHandler,
inject,
provideEnvironmentInitializer
} from '@angular/core';
import { provideRouter, Router } from '@angular/router';
import {
FirebaseErrorHandler,
setupCrashlyticsRoutes
} from '@firebase/crashlytics/angular';
import { FIREBASE_APP, provideFirebaseApp } from './firebase.config';
import { routes } from './app.routes';
import {
ApplicationConfig,
DestroyRef,
ErrorHandler,
inject,
provideEnvironmentInitializer
} from '@angular/core';
import { provideRouter, Router } from '@angular/router';
import { FirebaseApp } from '@firebase/app';
import {
FirebaseErrorHandler,
setupCrashlyticsRoutes
} from '@firebase/crashlytics/angular';
import { FIREBASE_APP, provideFirebaseApp } from './firebase.config';
import { routes } from './app.routes';

@MaesterChestnut
MaesterChestnut requested a review from rebehe August 25, 2026 17:56

@rebehe rebehe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants