common: check binfmt_misc for cross builds#3958
Closed
zhijianli88 wants to merge 1 commit intoflatcar:mainfrom
Closed
common: check binfmt_misc for cross builds#3958zhijianli88 wants to merge 1 commit intoflatcar:mainfrom
zhijianli88 wants to merge 1 commit intoflatcar:mainfrom
Conversation
Fail early when cross builds lack the required binfmt_misc entry in build_packages and build_image, matching SDK guidance. Ref: https://www.flatcar.org/docs/latest/reference/developer-guides/sdk-modifying-flatcar/#select-the-target-architecture Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Contributor
|
Thanks, but this won't actually be needed once #3678 is merged, which should happen this week. We're no longer going to rely on the implicit execution of QEMU. I have made improvements to Gentoo to explicitly execute it where necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail early when cross builds lack the required binfmt_misc entry
in build_packages and build_image, matching SDK guidance.
Ref: https://www.flatcar.org/docs/latest/reference/developer-guides/sdk-modifying-flatcar/#select-the-target-architecture
[Title: describe the change in one sentence]
[ describe the change in 1 - 3 paragraphs ]
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.