Skip to content

[two_dimensional_scrollables] Fix repainted trailing pinned cells#11624

Draft
Piinks wants to merge 1 commit intoflutter:mainfrom
Piinks:fix-185842
Draft

[two_dimensional_scrollables] Fix repainted trailing pinned cells#11624
Piinks wants to merge 1 commit intoflutter:mainfrom
Piinks:fix-185842

Conversation

@Piinks
Copy link
Copy Markdown
Contributor

@Piinks Piinks commented Apr 30, 2026

This PR fixes a performance bug in TableView where spans designated as trailing pinned were being incorrectly included in the range of "regular" (non-pinned) spans.

When the trailing pinned spans feature was introduced, these spans were appended to the end of the internal metrics maps. The logic in RenderTableViewport._updateFirstAndLastVisibleCell was defaulting the "last visible non-pinned index" to the very end of these maps (metrics.length - 1) whenever the binary search didn't find a clear boundary (e.g., when regular spans didn't fill the viewport).

This caused trailing pinned spans to be included in both the regular layout pass and the pinned layout pass. While visually hidden by clipping, this resulted in unnecessary iterations, building, and laying out of cells.

Updated _updateFirstAndLastVisibleCell in lib/src/table_view/table.dart to correctly cap the non-pinned range using the pre-calculated _lastRegularColumnIndex and _lastRegularRowIndex instead of the map length. This ensures the regular layout pass strictly terminates before reaching any trailing pinned spans.

Fixes flutter/flutter#185842

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Apr 30, 2026
@github-actions github-actions Bot added p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage labels Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] TableView trailing pinned spans are laid out twice

1 participant