[two_dimensional_scrollables] Fix repainted trailing pinned cells#11624
Draft
Piinks wants to merge 1 commit intoflutter:mainfrom
Draft
[two_dimensional_scrollables] Fix repainted trailing pinned cells#11624Piinks wants to merge 1 commit intoflutter:mainfrom
Piinks wants to merge 1 commit intoflutter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a performance bug in TableView where spans designated as trailing pinned were being incorrectly included in the range of "regular" (non-pinned) spans.
When the trailing pinned spans feature was introduced, these spans were appended to the end of the internal metrics maps. The logic in RenderTableViewport._updateFirstAndLastVisibleCell was defaulting the "last visible non-pinned index" to the very end of these maps (metrics.length - 1) whenever the binary search didn't find a clear boundary (e.g., when regular spans didn't fill the viewport).
This caused trailing pinned spans to be included in both the regular layout pass and the pinned layout pass. While visually hidden by clipping, this resulted in unnecessary iterations, building, and laying out of cells.
Updated _updateFirstAndLastVisibleCell in lib/src/table_view/table.dart to correctly cap the non-pinned range using the pre-calculated _lastRegularColumnIndex and _lastRegularRowIndex instead of the map length. This ensures the regular layout pass strictly terminates before reaching any trailing pinned spans.
Fixes flutter/flutter#185842
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2