Fix KeyError on empty __metadata__ in safetensors headers#89
Open
noobHappylife wants to merge 1 commit into
Open
Fix KeyError on empty __metadata__ in safetensors headers#89noobHappylife wants to merge 1 commit into
noobHappylife wants to merge 1 commit into
Conversation
Signed-off-by: noobhappylife <aratar1991@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SafeTensorsMetadataraisesKeyError: 'data_offsets'when a safetensors file's header contains an empty__metadata__: {}object. This breaks--load-format fastsafetensorsin vLLM for models shipped with empty metadata, e.g.MiniMaxAI/MiniMax-M3-MXFP8(all 31 shards have"__metadata__": {}).Fix
Strip metadata by key presence instead of truthiness.
Testing
Added test_from_file_empty_metadata, which writes a file with empty metadata via safetensors.save_file(metadata={}) and parses it with from_file.
Fixes the issue #88.