feat: regenerate API client from OpenAPI spec - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated regeneration via OpenAPI Generator (java/native) from
docs/v3/openapi3.yamlon frain-dev/convoy main. Hand-written webhook verify (src/main/java/com/getconvoy/webhook/) is untouched by the sync script.Note
Medium Risk
Renaming a serialized config field is a breaking change for Java SDK users still using
syncDynamicEventAck; new dynamic-URL behavior also affects how ingest endpoints are created.Overview
Regenerated Java client models for project config so SDK types match the updated OpenAPI spec (
DatastoreProjectConfig,ModelsProjectConfig).allow_unmatched_dynamic_urlsis added: when true, dynamic event URLs that do not match any endpoint URL template can auto-create an endpoint; default false rejects them.sync_dynamic_event_ackis renamed toverify_dynamic_events(JSON key and Java accessors). Behavior is unchanged in intent—control whetherPOST /events/dynamicwaits for endpoint/subscription resolution before a 2xx vs returning 201 after enqueue—but SDK callers must use the new property name.This is generated-only churn (equals/hashCode,
toUrlQueryString, etc.); no hand-written client logic in this diff.Reviewed by Cursor Bugbot for commit f6486ff. Bugbot is set up for automated code reviews on this repo. Configure here.