Renamer prerelease styles#646
Conversation
github-actions
Bot
added
the
Auto submit to Marketplace on merge
| icon = ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="11" |
There was a problem hiding this comment.
I expect cases like this are why we had 12 set as the parent element width/height (maybe the icon had a large perceived size so we dropped by 1?) but we seem to have lost that in the change
This file may be worth keeping that behaviour unless we can demonstrate it was a mistake before
There was a problem hiding this comment.
Nevermind I see you just moved it to the class which makes sense: https://github.com/framer/plugins/pull/646/changes#r3272172807
| </button> | ||
| ))} | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
these could probably be conditions over the className probably rather than duplicating the structure, we already have cx which is designed for this need
| padding: 15px; | ||
| } | ||
|
|
||
| [data-framer-styles="prerelease"] .container { |
There was a problem hiding this comment.
an alternative for the tabs could be to use this pattern instead, so that the new classes apply when data-framer-styles is set in the root
| .icon { | ||
| flex-shrink: 0; | ||
| width: 12px; | ||
| height: 12px; |
There was a problem hiding this comment.
Ah I see now, ignore my other comment then
2 participants
Description
This pull request adds prerelease styles to the Renamer plugin, including new icons and tabs design.
Screenshots: https://www.notion.so/framer/365adf6e8c968017adafebc517001a38
Changelog
Testing