Skip to content

build(gradle): Set group so composite substitution works automatically - #1410

Merged
runningcode merged 1 commit into
mainfrom
no/renovate-skip-snapshots-runtime
Aug 21, 2026
Merged

build(gradle): Set group so composite substitution works automatically#1410
runningcode merged 1 commit into
mainfrom
no/renovate-skip-snapshots-runtime

Conversation

@runningcode

@runningcode runningcode commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

For composite builds, dependency substitution works automatically. However because we aren't setting the group property in gradle, the dependency substituion doesn't work. This sets the group in gradle so that

This sets the group on the two projects using dependency substituion works properly.

This simplifies the code and should hopefully also fix the build error we are getting in renovate The root project is not yet available for build

GRADLE-116

#skip-changelog

@runningcode
runningcode force-pushed the no/renovate-skip-snapshots-runtime branch from eb0cea8 to f4aa1f9 Compare August 21, 2026 10:36
@runningcode runningcode changed the title build(deps): Skip snapshots-runtime build on dependency resolution runs build(gradle): Set group so composite substitution works automatically Aug 21, 2026
@runningcode
runningcode force-pushed the no/renovate-skip-snapshots-runtime branch from f4aa1f9 to fc8398a Compare August 21, 2026 11:58
Renovate's --write-verification-metadata invocation fails with "The root
project is not yet available for build". The cause is the explicit
dependencySubstitution block on sentry-snapshots-runtime: declaring
substitutions by hand is how you tell Gradle it need not configure an
included build to discover its coordinates, so nothing ever configures that
build, and WriteDependencyVerificationFile then walks every build in the tree
at build-finish and dies on the one with no root project.

Those blocks exist because automatic substitution was not matching, and it was
not matching because Gradle keys it off project.group:project.name while these
builds only declare GROUP, a Vanniktech maven-publish convention that sets the
publication coordinates and leaves project.group empty.

Set group from GROUP and drop both blocks. The substitution then happens
automatically, and discovering it configures the included builds, which is what
the verification metadata walk needs.

This also removes a footgun: with the blocks gone but no group, anything that
started depending on sentry-snapshots-runtime would have silently resolved
against a published artifact instead of the local build.

Publishing is untouched -- pom-default.xml and module.json are byte-identical
for both builds, because Vanniktech was already writing io.sentry into them.
@runningcode
runningcode force-pushed the no/renovate-skip-snapshots-runtime branch from fc8398a to cdeef57 Compare August 21, 2026 12:09
@runningcode
runningcode marked this pull request as ready for review August 21, 2026 13:06
@runningcode runningcode added the ship-it PR is ready to merge from a reviewer perspective label Aug 21, 2026
@runningcode
runningcode merged commit b2f92ba into main Aug 21, 2026
27 checks passed
@runningcode
runningcode deleted the no/renovate-skip-snapshots-runtime branch August 21, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ship-it PR is ready to merge from a reviewer perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants