Skip to content

feat!: remove DisableLogs and DisableMetrics options - #1392

Merged
giortzisg merged 3 commits into
masterfrom
chore/deprecate-disable-logs-metrics
Aug 26, 2026
Merged

feat!: remove DisableLogs and DisableMetrics options#1392
giortzisg merged 3 commits into
masterfrom
chore/deprecate-disable-logs-metrics

Conversation

@giortzisg

@giortzisg giortzisg commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description

This is a followup to #1306 and removes DisableMetrics and DisableLogs options. Users already need to use an integration or our own API to opt in to sending metrics and logs, so the option are somewhat conflicting.

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

Changelog Entry

  • removing DisableLogs and DisableMetrics client options. Sending metrics and logs is already gated by the usage of our APIs already, so having a global kill switch is counter intuitive. Users that won't to opt out should just not call the relevant APIs or setup the integrations.

@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

GO-158

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 446896e. Configure here.

Comment thread log_test.go

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My clanker found a stale reference to DisableLogs which should still be removed:

- Logs are enabled by default. If you have `DisableLogs: true`, remove it to enable log emission.

Otherwise, this looks good!

Remove the remaining README reference to DisableLogs now that this PR removes the option.

Co-Authored-By: GPT-5 Codex <noreply@openai.com>
@giortzisg
giortzisg merged commit c60a2f6 into master Aug 26, 2026
20 checks passed
@giortzisg
giortzisg deleted the chore/deprecate-disable-logs-metrics branch August 26, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Disable option for metrics and logs

2 participants