feat: add trace methods to public API - #1394
Open
giortzisg wants to merge 1 commit into
Open
Conversation
This adds trace, logging and metrics primitives so that integrations can be cleanly migrated to scopes and context.
giortzisg
force-pushed
the
scopes/integration-primitives
branch
from
August 24, 2026 10:53
4d788fd to
deeab0c
Compare
giortzisg
marked this pull request as ready for review
August 24, 2026 13:24
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit deeab0c. Configure here.
| return hub | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Span trace dropped without scope
High Severity
resolveTrace finds a span on the supplied context, then returns immediately when scope is nil without applying that span’s trace IDs. Logs and metrics now resolve scope via ScopeFromContext, which can be nil even when WithCtx carries an active span, so those signals lose TraceID/SpanID correlation.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit deeab0c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)