Skip to content

test: Fix telemetry tests to capture all envelopes#920

Open
timfish wants to merge 2 commits intomainfrom
timfish/test/fix-telemetry-tests
Open

test: Fix telemetry tests to capture all envelopes#920
timfish wants to merge 2 commits intomainfrom
timfish/test/fix-telemetry-tests

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Apr 30, 2026

There were two issues with the telemetry tests which were causing only a single session exit envelope to be captured:

  • Before bundler emit, the outDir didn't exist so the file appending was silently failing
  • Vite deletes the contents of the outDir before emit which removed the existing output

@timfish timfish marked this pull request as ready for review April 30, 2026 23:33
cursor[bot]

This comment was marked as outdated.

@timfish timfish force-pushed the timfish/test/fix-telemetry-tests branch from c479bd7 to b3bba09 Compare April 30, 2026 23:56
@timfish timfish force-pushed the timfish/test/fix-telemetry-tests branch from b3bba09 to dbc7dfe Compare May 1, 2026 00:00
@timfish timfish changed the title test: Fix telemetry test to capture all envelopes test: Fix telemetry tests to capture all envelopes May 1, 2026
@timfish timfish requested a review from chargome May 1, 2026 00:40
@timfish timfish enabled auto-merge (squash) May 1, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wider integration test coverage

1 participant