feat(core): Backfill otel attributes on streamed spans#20439
Open
feat(core): Backfill otel attributes on streamed spans#20439
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
will find another way of doing this |
chargome
force-pushed
the
cg/streamed-span-op-attribute
branch
from
73ad7b6 to
ae0c9db
Compare
chargome
changed the title
sentry.op onto streamed span attributes
chargome
changed the title
sentry.op on streamed spans
chargome
changed the title
sentry.op on streamed spans
chargome
changed the title
chargome
force-pushed
the
cg/streamed-span-op-attribute
branch
from
0c2d529 to
d602203
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c2e1043. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming path skips the
SentrySpanExporter, which is why we backfill span data (sentry.op,name,sentry.source) incaptureSpannow. Some of the inference logic is duplicated from the otel package — which we can likely drop once we move away from otel.closes #20425