Skip to content

chore(skill): Improve test skill to include nested playwright tests#20610

Merged
s1gr1d merged 1 commit intodevelopfrom
sig/test-skill-improve
Apr 30, 2026
Merged

chore(skill): Improve test skill to include nested playwright tests#20610
s1gr1d merged 1 commit intodevelopfrom
sig/test-skill-improve

Conversation

@s1gr1d
Copy link
Copy Markdown
Member

@s1gr1d s1gr1d commented Apr 30, 2026

Adds additional notes for using nested playwright tests as they spawn multiple Node processes in the integration tests and playwright also has recommendations on that. However, forEach does not support await, so a for ... of loop was added for those snippets.

Playwright recommends using .forEach for multiple tests: microsoft/playwright#7036 (comment)

@s1gr1d s1gr1d requested review from JPeer264 and chargome April 30, 2026 11:24
@s1gr1d s1gr1d merged commit fe75826 into develop Apr 30, 2026
36 checks passed
@s1gr1d s1gr1d deleted the sig/test-skill-improve branch April 30, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants