feat(billing): add EndTrial and OrganizationTrialEnded protos - #422
Draft
armenzg wants to merge 2 commits into
Draft
feat(billing): add EndTrial and OrganizationTrialEnded protos#422armenzg wants to merge 2 commits into
armenzg wants to merge 2 commits into
Conversation
Support ending billing-platform subscription trials early from admin via EngagementService, with a cache-busting trial-ended event. Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds protobuf messages so billing-platform can end an active subscription trial early (gsAdmin “End Trial Early”) and bust quota caches when that happens.
Changes
EndTrialRequest/EndTrialResponseunder engagement (endpoint_end_trial.proto)OrganizationTrialEndedevent payloadorganization_trial_endedintoEventPayloadCompanion getsentry PR will call these from
TrialService/EngagementServiceandput_platform.Notes
Generated Python is not committed (build with
make build-py). A release/VERSION bump will be needed before sentry can pin a published package.