Skip to content

ref: Make set_custom_sampling_context() a classmethod#6238

Merged
alexander-alderman-webb merged 1 commit intomasterfrom
webb/set-custom-sampling-context
May 8, 2026
Merged

ref: Make set_custom_sampling_context() a classmethod#6238
alexander-alderman-webb merged 1 commit intomasterfrom
webb/set-custom-sampling-context

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented May 8, 2026

Description

Remove uncertainty about which scope to call set_custom_sampling_context() on since the method always operates on the current scope. Allow users to call the method directly on the class.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 15.33s

All tests are passing successfully.

❌ Patch coverage is 63.64%. Project has 15054 uncovered lines.

Files with missing lines (5)
File Patch % Lines
scope.py 71.76% ⚠️ 253 Missing and 84 partials
aiohttp.py 9.46% ⚠️ 201 Missing
asgi.py 16.27% ⚠️ 175 Missing and 1 partials
wsgi.py 17.74% ⚠️ 153 Missing
__init__.py 94.66% ⚠️ 15 Missing and 15 partials

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title ref: Make set_custom_sampling_context a classmethod ref: Make set_custom_sampling_context() a classmethod May 8, 2026
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review May 8, 2026 10:43
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner May 8, 2026 10:43
@alexander-alderman-webb alexander-alderman-webb merged commit a5f5a8d into master May 8, 2026
156 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/set-custom-sampling-context branch May 8, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants