build(deps): Bump sqlparse to 0.6.0 and sql-metadata to 3.0.1 - #8398
Merged
Conversation
Bumps [sqlparse](https://github.com/andialbrecht/sqlparse) from 0.5.4 to 0.6.0. - [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG) - [Commits](andialbrecht/sqlparse@0.5.4...0.6.0) --- updated-dependencies: - dependency-name: sqlparse dependency-version: 0.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 391e17f. Configure here.
| source = { registry = "https://pypi.devinfra.sentry.io/simple" } | ||
| wheels = [ | ||
| { url = "https://pypi.devinfra.sentry.io/wheels/sql_metadata-2.11.0-py3-none-any.whl", hash = "sha256:2ce9d4519565a972edf786712d3f6fbebf8ddd8e0d7bdb4bf51d64f5ec2e5c88" }, | ||
| { url = "https://pypi.devinfra.sentry.io/wheels/sqlglot-30.16.0-py3-none-any.whl", hash = "sha256:f14f119e87bb1397316ab2b3c1f12dddd3b098921185dc69935952111be91788" }, |
There was a problem hiding this comment.
Silent sql-metadata major upgrade
High Severity
Raising sqlparse to >=0.6.0 forces sql-metadata from 2.11.0 to 3.0.1 because 2.x requires sqlparse<0.6.0. That major release replaces sqlparse with sqlglot and changes parsing. Admin validate_ro_query relies on Parser / QueryType for ClickHouse SQL (including ARRAY JOIN), so allowlisting and SELECT checks can behave differently or error.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 391e17f. Configure here.
phacops
approved these changes
Aug 27, 2026
sql-metadata 2.x cannot resolve with sqlparse>=0.6.0, so make the major bump explicit in pyproject.toml.
phacops
changed the title
phacops
enabled auto-merge (squash)
August 27, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparse 0.6.0 fixes several lexer and formatter DoS CVEs, but sql-metadata 2.x cannot resolve against it (
sqlparse<0.6.0). This also takes sql-metadata 3.0.1, which swaps the parser from sqlparse to sqlglot.Snuba-admin
validate_ro_querystill usesParser/QueryTypeto require SELECT. Production table allowlisting continues to use ClickHouseEXPLAIN QUERY TREE;parsed.tablesis only the no-connection fallback. After this upgrade sqlparse stays a direct dependency but is unused by application code.Unsupported statements such as
EXPLAIN/DESCRIBE/SHOWnow raise sql-metadata'sInvalidQueryDefinitioninstead ofInvalidCustomQueryif they reach the parser.