feat(taskbroker-client): expose task enqueue producer future - #741
Merged
Conversation
lvthanh03
force-pushed
the
tony/apply-async-with-future
branch
from
July 3, 2026 16:49
5e59093 to
d1f76e3
Compare
untitaker
reviewed
Jul 6, 2026
| wait_for_delivery=self.wait_for_delivery, | ||
| ) | ||
|
|
||
| def apply_async_with_future( |
Member
There was a problem hiding this comment.
why can't we make apply_async return the future? It's not a breaking change to do so
Member
Author
There was a problem hiding this comment.
I thought there might be some risk in changing the public client API contract for every task dispatch, though I just checked in sentry and there isn't any code that uses the return value of apply_async so we won't break any exisitng logic if we make apply async return the future.
Either way, I think it's clearer to only return the producer future when the user explicitly asks for it back.
untitaker
approved these changes
Jul 6, 2026
bmckerry
approved these changes
Jul 6, 2026
evanh
approved these changes
Jul 6, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs STREAM-1309
Modifies
TaskNamespace.send_task()to return the existing producer future, and addsTask.apply_async_with_future()for dispatching a task and also returning that producer future.This lets callers coordinate task enqueue delivery; in the case of the spans buffer enqueueing the process_segment task, it needs to know that the produce succeeded before calling
done_flush_segments.