-
-
Notifications
You must be signed in to change notification settings - Fork 9
ref(o11y): Remove redundant span status assignment #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1e90734
test: Initialize SDK in relevant tests
alexander-alderman-webb 5de3e0d
remove dead code
alexander-alderman-webb d570be1
ref(o11y): Remove redundant span status assignment
alexander-alderman-webb 49883c8
move fixtures after mocks
alexander-alderman-webb d6ea809
remove sentry_init from frequency test
alexander-alderman-webb 9c64fa8
configure sdk to avoid sleeps
alexander-alderman-webb 0268df0
Merge branch 'webb/add-init-to-tests' into webb/remove-explicit-status
alexander-alderman-webb ea6dba3
fix import ordering problem
alexander-alderman-webb 32fd19d
cleanup in fixture
alexander-alderman-webb 43ec0e3
Merge branch 'webb/add-init-to-tests' into webb/remove-explicit-status
alexander-alderman-webb 265e126
remove unused parameter
alexander-alderman-webb 2b52bbc
simplify transport
alexander-alderman-webb 6f7f6a4
Merge branch 'webb/add-init-to-tests' into webb/remove-explicit-status
alexander-alderman-webb 35831f8
revert test changes
alexander-alderman-webb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this being set in the new code? Does the sdk do this automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in the SDK. It's set in
Span.__exit__()(orStreamedSpan.__exit__()) in the SDK (invoked when the context manager exits). The link to the former is below.https://github.com/getsentry/sentry-python/blob/3a50950e632d9923f45a9b6fb18d89e1f27badad/sentry_sdk/tracing.py#L395