Remove duplicate reusable inGitHub-hosted runners concept page#44044
Remove duplicate reusable inGitHub-hosted runners concept page#44044marekdkropiewnicki-dotcom wants to merge 1 commit intogithub:mainfrom
Conversation
### Why `content/actions/concepts/runners/github-hosted-runners.md` includes the `reusables.actions.enterprise-github-hosted-runners` reusable twice — once before the `## Overview of GitHub-hosted runners` heading and again immediately after it — causing the same banner to render twice on https://docs.github.com/en/actions/concepts/runners/github-hosted-runners. ### What Removes the second (duplicate) occurrence of the reusable. The first occurrence is unchanged. No other edits.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
Bot
added
the
triage
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
Removes a duplicated enterprise banner reusable from the GitHub-hosted runners concept article to prevent the banner from rendering twice on docs.github.com.
Changes:
- Removed the second occurrence of
{% data reusables.actions.enterprise-github-hosted-runners %}near the top of the page. - (Unintended) Modified the “Overview” heading text (plural → singular), which should likely be reverted.
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runners | ||
|
|
||
| {% data reusables.actions.enterprise-github-hosted-runners %} | ||
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runner |
There was a problem hiding this comment.
This line uses {% data variables.product.prodname_dotcom %}, which is marked DO NOT USE in data/variables/product.yml (it outputs the same as variables.product.github). Since this line is being edited anyway, switch to {% data variables.product.github %} (or prodname_dotcom_the_website only if you truly need “GitHub.com”).
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runner | |
| ## Overview of {% data variables.product.github %}-hosted runner |
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runners | ||
|
|
||
| {% data reusables.actions.enterprise-github-hosted-runners %} | ||
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runner |
There was a problem hiding this comment.
The heading was changed from “...-hosted runners” to singular “...-hosted runner”. This looks like an accidental typo and also changes the generated anchor, which can break existing bookmarks/links. Suggest reverting the heading text back to plural.
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runner | |
| ## Overview of {% data variables.product.prodname_dotcom %}-hosted runners |
Why
content/actions/concepts/runners/github-hosted-runners.mdincludes thereusables.actions.enterprise-github-hosted-runnersreusable twice — once before the## Overview of GitHub-hosted runnersheading and again immediately after it — causing the same banner to render twice on https://docs.github.com/en/actions/concepts/runners/github-hosted-runners.What
Removes the second (duplicate) occurrence of the reusable. The first occurrence is unchanged.
No other edits.
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: