Added warning message about git extension no longer being enabled by default by aaronrsun · Pull Request #2197 · github/spec-kit

aaronrsun · 2026-04-12T23:30:31Z

Addresses: #2165
Spec doc: #2196

Copilot

Pull request overview

Adds a post-init warning to inform users that the bundled git extension will no longer be enabled by default starting in v1.0.0, and introduces tests/spec documentation for that notice.

Changes:

Track whether the bundled git extension was freshly installed during specify init and, if so, print a Rich warning panel about the upcoming default-behavior change.
Add CLI tests covering when the deprecation notice should/shouldn’t appear.
Add a feature spec documenting the motivation and acceptance criteria.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`src/specify_cli/__init__.py`	Tracks fresh git extension installation and prints an “Upcoming Change” warning panel after init completes.
`tests/extensions/git/test_git_extension.py`	Adds coverage to ensure the warning appears only when the git extension is newly installed (and not with `--no-git`).
`.specify/features/git-extension-deprecation-notice/spec.md`	Documents the intended behavior and messaging for the deprecation notice.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…default

Copilot

Pull request overview

Adds a user-facing warning during specify init to notify users that the bundled git extension will stop being enabled by default starting in v1.0.0, along with tests to validate when the notice appears.

Changes:

Track whether the bundled git extension was freshly installed during specify init.
Print a yellow Rich Panel notice after initialization when the git extension was auto-installed.
Add CLI-level tests covering notice shown/not shown scenarios.

Show a summary per file

File	Description
`src/specify_cli/__init__.py`	Tracks fresh git extension install and prints a post-init deprecation notice panel.
`tests/extensions/git/test_git_extension.py`	Adds tests asserting the notice appears only on fresh git extension install and not with `--no-git` / already-installed scenarios.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 1

mnriem

Would it be possible that the extension itself vends the message during its setup?

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Add type validation in install_notice property (coerce to str) - Add isinstance guard before calling .strip() in init - Patch _locate_bundled_extension in tests for deterministic behavior - Use strip_ansi() on output before assertions to handle ANSI codes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

aaronrsun · 2026-04-18T20:30:28Z

Would it be possible that the extension itself vends the message during its setup?

@mnriem Addressed your comment as well as all of Copilot's. Please take a look again.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

aaronrsun requested a review from mnriem as a code owner April 12, 2026 23:30

Copilot AI review requested due to automatic review settings April 12, 2026 23:30

Copilot started reviewing on behalf of aaronrsun April 12, 2026 23:31 View session

Copilot AI reviewed Apr 12, 2026

View reviewed changes

Comment thread src/specify_cli/__init__.py Outdated

Comment thread tests/extensions/git/test_git_extension.py Outdated

Added warning message about git extension no longer being enabled by …

1c7350d

…default

aaronrsun force-pushed the fix-issue-2165 branch from 504cb5d to 1c7350d Compare April 12, 2026 23:34

aaronrsun mentioned this pull request Apr 12, 2026

Created spec for issue #2165 #2196

Closed

mnriem requested a review from Copilot April 13, 2026 12:49

Copilot started reviewing on behalf of mnriem April 13, 2026 12:49 View session

mnriem self-assigned this Apr 13, 2026

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread src/specify_cli/__init__.py Outdated

mnriem requested changes Apr 13, 2026

View reviewed changes

Merge branch 'main' into fix-issue-2165

56750c3

Copilot AI review requested due to automatic review settings April 18, 2026 18:49

Copilot started reviewing on behalf of aaronrsun April 18, 2026 18:49 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread tests/extensions/git/test_git_extension.py

Copilot AI review requested due to automatic review settings April 18, 2026 19:22

Copilot started reviewing on behalf of aaronrsun April 18, 2026 19:22 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/__init__.py Outdated

Comment thread tests/extensions/git/test_git_extension.py Outdated

aaronrsun force-pushed the fix-issue-2165 branch 2 times, most recently from 710d2f5 to a6f1e58 Compare April 18, 2026 19:27

Copilot AI review requested due to automatic review settings April 18, 2026 19:36

aaronrsun force-pushed the fix-issue-2165 branch from a6f1e58 to 6dca363 Compare April 18, 2026 19:36

Copilot started reviewing on behalf of aaronrsun April 18, 2026 19:36 View session

Display deprication warning during git extension setup

68edf49

aaronrsun force-pushed the fix-issue-2165 branch from 6dca363 to 68edf49 Compare April 18, 2026 19:37

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread extensions/git/extension.yml Outdated

Comment thread src/specify_cli/__init__.py Outdated

Comment thread tests/extensions/git/test_git_extension.py Outdated

Explicitly stated that specify-cli needs to be opted in

54d3723

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 18, 2026 20:11

Copilot started reviewing on behalf of aaronrsun April 18, 2026 20:12 View session

aaronrsun and others added 2 commits April 18, 2026 13:12

nit: fixed naming convention

9cbb82f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Updated unit tests

68dacfa

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread src/specify_cli/__init__.py Outdated

aaronrsun mentioned this pull request Apr 18, 2026

Add notice that git extension will no longer be enabled by default at 1.0.0 #2165

Open

3 tasks

aaronrsun requested review from Copilot and mnriem April 18, 2026 20:32

Copilot started reviewing on behalf of aaronrsun April 18, 2026 20:33 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Conversation

aaronrsun commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

aaronrsun commented Apr 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aaronrsun commented Apr 12, 2026 •

edited

Loading