fix(integrations): migrate Antigravity (agy) layout to .agents/ and deprecate --skills by baveku · Pull Request #2276 · github/spec-kit

baveku · 2026-04-20T04:08:58Z

Description

Changes

Directory Migration: Switched the default integration storage folder from .agent/ to .agents/.
Auto-Migration: Added a seamless shutil.move migration step in AgyIntegration.setup() to auto-rename .agent/ to .agents/ if the new directory doesn't exist yet, preventing breakage for legacy projects.
Backward Compatibility: Retained --skills as a deprecated, no-op flag instead of removing it completely to ensure existing automation scripts do not break during option parsing.
Version Warning: Added a setup warning indicating that the new .agents/ layout requires Antigravity v1.20.5 or newer.

Testing

Tested locally with uv run specify --help
Ran existing tests with uv sync && uv run pytest
Verified the directory change in agy/integrations/__init__.py

AI Disclosure

I did not use AI assistance for this contribution
I did use AI assistance (describe below)

Copilot

Pull request overview

Updates the Antigravity (agy) integration to use the newer .agents directory layout instead of .agent, aligning with updated Antigravity IDE specs.

Changes:

Switched the default integration storage folder from .agent/ to .agents/.
Updated the registrar directory from .agent/skills to .agents/skills.
Updated the --skills option help text to reference a newer Antigravity version.

Show a summary per file

File	Description
`src/specify_cli/integrations/agy/__init__.py`	Updates agy integration paths to `.agents` and refreshes the `--skills` help text.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

src/specify_cli/integrations/agy/init.py:39

The help text says --skills is the default since v1.23.2, but the module docstring still states the default changed in v1.20.5. Please reconcile these version statements (either update the docstring version or clarify what changed in each release) to avoid confusing users.

                help="Install as agent skills (default for Antigravity since v1.23.2)",

Files reviewed: 1/1 changed files
Comments generated: 1

mnriem

Please address Copilot feedback. Also note that if this requires a newer version of agy installed you should warn users about this when the integration gets installed. Also please include a test when changing behavior

… and add version compatibility warnings

Copilot

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

src/specify_cli/integrations/agy/init.py:65

Emitting terminal output directly from setup() is likely to interfere with the Rich Live(...) progress UI used by specify init (the integration setup runs inside a Live context). Consider moving this warning to the CLI layer (so it can be rendered via the existing Rich console/panels) or routing it through a logger/structured return value instead of printing during setup.

        import click

        click.secho(
            "Warning: The .agents/ layout requires Antigravity v1.19.5 or newer. "
            "Please ensure your agy installation is up to date.",
            fg="yellow",
            err=True,
        )
        return super().setup(project_root, manifest, parsed_options=parsed_options, **opts)

Files reviewed: 2/2 changed files
Comments generated: 2

mnriem · 2026-04-20T15:33:27Z

Please address Copilot support. BTW what is the reason for mentioning --skills? Can we get rid of that? Thoughts?

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

baveku · 2026-04-20T15:41:56Z

Please address Copilot support. BTW what is the reason for mentioning --skills? Can we get rid of that? Thoughts?

Good catch! Since explicit command support was deprecated in v1.20.5, the .agents/skills/ layout is now the only supported behavior for the Antigravity integration. The --skills flag was essentially a redundant legacy option with no actual branching logic.
I've completely removed it from AgyIntegration, cleaned up the outdated docstrings, and updated the test suite to reflect its removal.

…ate related test assertions

Copilot

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…emove obsolete tests

Copilot

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

src/specify_cli/integrations/agy/init.py:53

This PR adds behavior beyond the PR description: AgyIntegration now emits a setup-time warning and (by removing the previous options() override) drops the integration-level --skills option. Please update the PR description (and any release notes if applicable) to reflect these user-visible changes so reviewers/users don’t miss them.

        self,
        project_root: Path,
        manifest: IntegrationManifest,
        parsed_options: dict[str, Any] | None = None,
        **opts: Any,
    ) -> list[Path]:
        import click

        click.secho(
            "Warning: The .agents/ layout requires Antigravity v1.20.5 or newer. "
            "Please ensure your agy installation is up to date.",
            fg="yellow",
            err=True,
        )
        return super().setup(project_root, manifest, parsed_options=parsed_options, **opts)

Files reviewed: 2/2 changed files
Comments generated: 1

mnriem · 2026-04-20T16:04:22Z

Please address Test & Lint errors

…estoration test

Copilot

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 1

mnriem · 2026-04-20T16:19:06Z

Please address Copilot feedback

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 1

mnriem · 2026-04-20T16:41:05Z

Please change PR title / description to match intent of the PR as per Copilot feedback

baveku · 2026-04-20T16:55:43Z

Please change PR title / description to match intent of the PR as per Copilot feedback

I've updated the PR title and description to accurately reflect the changes. It now explicitly details the auto-migration step we added, the retention of the --skills flag for backward compatibility, and the new version warning. Thanks for the feedback!

mnriem · 2026-04-20T16:57:52Z

Thank you!

refactor(agy): update storage directory from .agent to .agents

ed8caa3

baveku requested a review from mnriem as a code owner April 20, 2026 04:08

mnriem requested a review from Copilot April 20, 2026 14:38

Copilot started reviewing on behalf of mnriem April 20, 2026 14:39 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/agy/__init__.py

mnriem requested changes Apr 20, 2026

View reviewed changes

feat: update Antigravity integration to use .agents/ directory layout…

2f62314

… and add version compatibility warnings

mnriem requested a review from Copilot April 20, 2026 15:25

Copilot started reviewing on behalf of mnriem April 20, 2026 15:26 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread tests/integrations/test_integration_agy.py Outdated

Comment thread src/specify_cli/integrations/agy/__init__.py Outdated

Apply suggestion from @Copilot

ad6cdb2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

baveku added 2 commits April 20, 2026 22:42

refactor: remove deprecated --skills flag from AgyIntegration and upd…

0aafaf9

…ate related test assertions

Merge branch 'main' of github.com:baveku/spec-kit

fc2c64e

mnriem requested a review from Copilot April 20, 2026 15:48

Copilot started reviewing on behalf of mnriem April 20, 2026 15:48 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/agy/__init__.py Outdated

Comment thread tests/integrations/test_integration_agy.py Outdated

Comment thread src/specify_cli/integrations/agy/__init__.py

Update src/specify_cli/integrations/agy/__init__.py

e262d58

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mnriem requested a review from Copilot April 20, 2026 15:54

Copilot started reviewing on behalf of mnriem April 20, 2026 15:55 View session

baveku added 2 commits April 20, 2026 22:56

refactor: update Antigravity integration requirement to v1.20.5 and r…

8ab0c55

…emove obsolete tests

Merge branch 'main' of github.com:baveku/spec-kit

1decd87

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/agy/__init__.py

test: update skills directory path from .agent to .agents in preset r…

6a86ebe

…estoration test

mnriem requested a review from Copilot April 20, 2026 16:12

Copilot started reviewing on behalf of mnriem April 20, 2026 16:13 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread tests/integrations/test_integration_agy.py Outdated

Update tests/integrations/test_integration_agy.py

34fd3b9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mnriem requested a review from Copilot April 20, 2026 16:24

Copilot started reviewing on behalf of mnriem April 20, 2026 16:24 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread tests/integrations/test_integration_agy.py Outdated

Update tests/integrations/test_integration_agy.py

d1c57ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mnriem requested a review from Copilot April 20, 2026 16:34

Copilot started reviewing on behalf of mnriem April 20, 2026 16:34 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/agy/__init__.py

baveku changed the title ~~refactor(agy): update storage directory from .agent to .agents~~ fix(integrations): migrate Antigravity (agy) layout to .agents/ and deprecate --skills Apr 20, 2026

mnriem self-requested a review April 20, 2026 16:57

mnriem approved these changes Apr 20, 2026

View reviewed changes

mnriem merged commit 2568422 into github:main Apr 20, 2026
15 checks passed

Conversation

baveku commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

AI Disclosure

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

mnriem commented Apr 20, 2026

Uh oh!

baveku commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

mnriem commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

mnriem commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

mnriem commented Apr 20, 2026

Uh oh!

baveku commented Apr 20, 2026

Uh oh!

Uh oh!

mnriem commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

baveku commented Apr 20, 2026 •

edited

Loading