Introduce GlobusApp.logout(sweep=True) - #1415
Merged
Merged
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
August 6, 2026 16:23
derek-globus
requested changes
Aug 6, 2026
| return False | ||
|
|
||
| def logout(self) -> None: | ||
| # TODO: sweep should default to True in globus-sdk v5+ |
Contributor
There was a problem hiding this comment.
This isn't the right way to document that intention imo.
There's an epic here where we're accumulating v5 plans.
As I mentioned in slack, I separately don't actually think we should do this. But if you want to discuss the idea, could you create a story there instead of a TODO here?
Member
Author
There was a problem hiding this comment.
Sorry, yes, that comment was written contemporaneously with our conversation. Let me remove it.
I'm not going to create other tracking, since I think it needs some amount of further discussion first.
This new flag codifies how to clear all tokens for services currently registered with the app (typically via clients).
derek-globus
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new flag codifies how to clear all tokens for services currently
registered with the app (typically via clients).