docs: point the docs-site links at pages that exist - #6
Closed
hamidfzm wants to merge 1 commit into
Closed
Conversation
The three deep links into glyph-md.github.io/plugins dropped the .html extension, so all of them 404'd; only the bare site root resolved. The exported pages are <page>.html at the site root.
Member
Author
|
Not needed. The links were 404ing because the pages lived at Closing; nothing to change here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All three deep links into the plugin docs site 404'd. Only the bare site root resolved, so anyone following "Getting Started" from this template landed on a 404 and concluded there was no docs site.
The website export writes one HTML file per markdown page, so the pages are
<page>.html. The links now carry the extension.Ordering
This targets the site layout from glyph-md/plugins#5 (export
docs/only, so itsREADME.mdbecomes the site index and the pages sit at the root). Merge glyph-md/plugins#5 first, otherwise these links point at the layout that has not shipped yet and stay 404 until it does.Not included
The
types/glyph.d.tsheader still says API0.17.0while the host is at0.20.0. Bumping it means asserting the 0.18 to 0.20 surface is mirrored in the declarations, which needs an audit of its own.