Use non-deprecated qcheck combinators#2059
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Goblint’s QCheck usage to avoid deprecation warnings on newer QCheck releases by switching to the non-deprecated combinator names and bumping the minimum/locked QCheck versions accordingly.
Changes:
- Replace deprecated
QCheck.small_listwithQCheck.list_smallin domainarbitrarygenerators. - Replace deprecated
QCheck.oneofl/QCheck.frequencywithQCheck.oneof_list/QCheck.oneof_weighted. - Update opam metadata to require newer QCheck (
qcheck-core >= 0.90) and lock to0.91.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/domain/setDomain.ml |
Updates deprecated list/choice combinators used in arbitrary generators. |
src/domain/hoareDomain.ml |
Updates deprecated list combinator used in arbitrary generator. |
src/common/domains/printable.ml |
Replaces frequency with oneof_weighted for weighted generator choice. |
src/cdomain/value/cdomains/int/intervalSetDomain.ml |
Updates deprecated list combinator used in generator construction. |
src/cdomain/value/cdomains/int/enumsDomain.ml |
Replaces frequency with oneof_weighted in generator definition. |
src/cdomain/value/cdomains/int/defExcDomain.ml |
Replaces frequency with oneof_weighted in generator definition. |
goblint.opam.locked |
Locks qcheck-core / qcheck-ounit to 0.91. |
goblint.opam |
Raises minimum required qcheck-core version to >= 0.90. |
dune-project |
Raises minimum required qcheck-core version to >= 0.90 for generated opam metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michael-schwarz
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unlocked CI jobs (and opam-repository CI) show a bunch of deprecation warnings for qcheck on newer versions.
This upgrades Goblint to those newer versions with non-deprecated combinator names.