fix(react): use pickup location address for tax calculation on billing updates#1355
Open
nlaverde-godaddy wants to merge 2 commits intogodaddy:mainfrom
Open
fix(react): use pickup location address for tax calculation on billing updates#1355nlaverde-godaddy wants to merge 2 commits intogodaddy:mainfrom
nlaverde-godaddy wants to merge 2 commits intogodaddy:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 5ed839a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a customer selects in-person pickup and edits their billing address (even just deleting and re-typing a digit), the tax calculation was using the wrong address, resulting in incorrect tax amounts.
#Root cause
Root Cause: In
use-update-order.ts, when the billing address was updated,updateTaxes.mutate()was called with undefined, causing the backend to use the customer's billing address instead of the pickup location address for tax calculation.Example of the bug:
Pickup location zipcode: 30143 (7% tax rate)
Customer billing zipcode: 30734 (8% tax rate)
First calculation: Correctly uses pickup location → 7% ✅
After editing billing address: Uses customer address → 8% ❌ (now fixed)
Related ticket: https://godaddy-corp.atlassian.net/browse/CIEC-11081
Changeset
Test Plan
Test Plan
Unit Tests (9 new tests):
✅ Returns pickup location address for PICKUP delivery method
✅ Returns correct location when multiple locations exist
✅ Returns undefined if pickup location not found
✅ Returns undefined if locations array is empty
✅ Returns undefined if locations is undefined
✅ Returns undefined for SHIP delivery method
✅ Returns undefined when delivery method is undefined
✅ Handles pickupLocationId being undefined for pickup
✅ Handles empty string pickupLocationId for pickup