Skip to content

Sync from gdc-ui/sdk hash:8167f3b#7347

Merged
yenkins-admin merged 2 commits into
masterfrom
sync-from-gdc-ui-28991015161
Jul 9, 2026
Merged

Sync from gdc-ui/sdk hash:8167f3b#7347
yenkins-admin merged 2 commits into
masterfrom
sync-from-gdc-ui-28991015161

Conversation

@yenkins

@yenkins yenkins commented Jul 9, 2026

Copy link
Copy Markdown

Automated sync of gdc-ui → gooddata-ui-sdk Source hash: 8167f3b

Summary by CodeRabbit

  • New Features

    • Added support for a new authentication option in data source workflows.
    • Improved sharing so transfer-ownership actions appear only when allowed.
  • Bug Fixes

    • Updated dashboard date filter behavior to handle empty values more consistently.
    • Refined export visibility and availability across dashboard and insight views.
    • Removed outdated widget overlay indicators from the dashboard experience.
  • Chores

    • Bumped package and release versions across the workspace.

@yenkins yenkins added the sync PR is created from gdc-ui label Jul 9, 2026

@yenkins-admin yenkins-admin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by sync workflow

@yenkins-admin yenkins-admin enabled auto-merge July 9, 2026 03:19
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 69c437da-6814-4ee4-a928-43b5853e102e

📥 Commits

Reviewing files that changed from the base of the PR and between 238669c and 1c66a0d.

⛔ Files ignored due to path filters (1)
  • common/config/rush/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (103)
  • NOTICE
  • common/changes/@gooddata/sdk-ui-all/nen-cq-2505_2026-07-01-11-12-53.json
  • common/config/rush/version-policies.json
  • examples/playground/package.json
  • examples/sdk-interactive-examples/examples-template/package.json
  • examples/sdk-interactive-examples/examples/example-attributefilter/package.json
  • examples/sdk-interactive-examples/examples/example-chartconfig/package.json
  • examples/sdk-interactive-examples/examples/example-columnchart/package.json
  • examples/sdk-interactive-examples/examples/example-combochart/package.json
  • examples/sdk-interactive-examples/examples/example-dashboard/package.json
  • examples/sdk-interactive-examples/examples/example-datefilter/package.json
  • examples/sdk-interactive-examples/examples/example-dependentfilters/package.json
  • examples/sdk-interactive-examples/examples/example-execute/package.json
  • examples/sdk-interactive-examples/examples/example-granularity/package.json
  • examples/sdk-interactive-examples/examples/example-headline/package.json
  • examples/sdk-interactive-examples/examples/example-pivottable/package.json
  • examples/sdk-interactive-examples/examples/example-relativedatefilter/package.json
  • examples/sdk-interactive-examples/examples/example-repeater/package.json
  • examples/sdk-interactive-examples/package.json
  • libs/api-client-tiger/package.json
  • libs/sdk-backend-base/package.json
  • libs/sdk-backend-mockingbird/package.json
  • libs/sdk-backend-spi/package.json
  • libs/sdk-backend-tiger/api/sdk-backend-tiger.api.md
  • libs/sdk-backend-tiger/package.json
  • libs/sdk-backend-tiger/src/backend/features/feature.ts
  • libs/sdk-backend-tiger/src/backend/tigerSpecificFunctions.ts
  • libs/sdk-backend-tiger/src/backend/uiFeatures.ts
  • libs/sdk-code-convertors/package.json
  • libs/sdk-code-convertors/python/pyproject.toml
  • libs/sdk-code-schemas/package.json
  • libs/sdk-e2e-utils/package.json
  • libs/sdk-embedding/package.json
  • libs/sdk-model/api/sdk-model.api.md
  • libs/sdk-model/package.json
  • libs/sdk-model/src/settings/settings.ts
  • libs/sdk-pluggable-application-model/package.json
  • libs/sdk-ui-all/package.json
  • libs/sdk-ui-application-header/package.json
  • libs/sdk-ui-catalog/package.json
  • libs/sdk-ui-catalog/src/catalogDetail/share/CatalogItemShareProvider.tsx
  • libs/sdk-ui-catalog/src/catalogDetail/share/tests/CatalogItemShareProvider.test.tsx
  • libs/sdk-ui-charts/package.json
  • libs/sdk-ui-dashboard/api/sdk-ui-dashboard.api.md
  • libs/sdk-ui-dashboard/package.json
  • libs/sdk-ui-dashboard/src/_staging/dateFilterConfig/tests/validation.test.ts
  • libs/sdk-ui-dashboard/src/_staging/dateFilterConfig/validation.ts
  • libs/sdk-ui-dashboard/src/index.ts
  • libs/sdk-ui-dashboard/src/model/store/config/configSelectors.ts
  • libs/sdk-ui-dashboard/src/model/store/executionResults/executionResultsSelectors.ts
  • libs/sdk-ui-dashboard/src/model/store/widgetExports/widgetExportsSelectors.ts
  • libs/sdk-ui-dashboard/src/presentation/filterBar/dateFilter/DefaultDashboardDateFilter.tsx
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardItemOverlay/DashboardItemOverlay.tsx
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardItemOverlay/DashboardItemOverlayController.tsx
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardLayoutWidget.tsx
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DefaultDashboardLayoutRenderer/DashboardLayoutSection.tsx
  • libs/sdk-ui-dashboard/src/presentation/localization/bundles/en-US.json
  • libs/sdk-ui-dashboard/src/presentation/widget/common/useInsightExport.ts
  • libs/sdk-ui-dashboard/src/presentation/widget/insight/ViewModeDashboardInsight/InsightDrillDialog/DrillDialog.tsx
  • libs/sdk-ui-ext/api/sdk-ui-ext.api.md
  • libs/sdk-ui-ext/package.json
  • libs/sdk-ui-ext/src/share/ObjectShareDialog.tsx
  • libs/sdk-ui-ext/src/share/objectShareController.types.ts
  • libs/sdk-ui-ext/src/share/tests/ObjectShareDialog.test.tsx
  • libs/sdk-ui-ext/src/share/tests/useObjectShareController.test.tsx
  • libs/sdk-ui-ext/src/share/useAccessList.ts
  • libs/sdk-ui-ext/src/share/useObjectShareController.ts
  • libs/sdk-ui-filters/package.json
  • libs/sdk-ui-gen-ai/package.json
  • libs/sdk-ui-geo/package.json
  • libs/sdk-ui-kit/package.json
  • libs/sdk-ui-loaders/package.json
  • libs/sdk-ui-pivot/package.json
  • libs/sdk-ui-pluggable-application/package.json
  • libs/sdk-ui-pluggable-host/package.json
  • libs/sdk-ui-semantic-search/package.json
  • libs/sdk-ui-tests-app/package.json
  • libs/sdk-ui-tests-e2e/package.json
  • libs/sdk-ui-tests-reference-workspace/package.json
  • libs/sdk-ui-tests-scenarios/package.json
  • libs/sdk-ui-tests-storybook/package.json
  • libs/sdk-ui-theme-provider/package.json
  • libs/sdk-ui-vis-commons/package.json
  • libs/sdk-ui-web-components/package.json
  • libs/sdk-ui/package.json
  • libs/util/package.json
  • templates/pluggable-module/harness/package.json
  • templates/pluggable-module/module/package.json
  • tools/app-toolkit/package.json
  • tools/applink/package.json
  • tools/catalog-export/package.json
  • tools/create-pluggable-module/package.json
  • tools/dashboard-plugin-template/package.json
  • tools/eslint-config/package.json
  • tools/i18n-toolkit/package.json
  • tools/lint-config/package.json
  • tools/mock-handling/package.json
  • tools/oxlint-config/package.json
  • tools/plugin-toolkit/package.json
  • tools/react-app-template/package.json
  • tools/reference-workspace-mgmt/package.json
  • tools/reference-workspace/package.json
  • tools/stylelint-config/package.json
💤 Files with no reviewable changes (9)
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardItemOverlay/DashboardItemOverlay.tsx
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardItemOverlay/DashboardItemOverlayController.tsx
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DefaultDashboardLayoutRenderer/DashboardLayoutSection.tsx
  • libs/sdk-ui-dashboard/src/model/store/widgetExports/widgetExportsSelectors.ts
  • libs/sdk-ui-dashboard/src/model/store/config/configSelectors.ts
  • libs/sdk-ui-dashboard/src/presentation/localization/bundles/en-US.json
  • libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardLayoutWidget.tsx
  • libs/sdk-ui-dashboard/src/index.ts
  • libs/sdk-ui-dashboard/api/sdk-ui-dashboard.api.md

📝 Walkthrough

Walkthrough

Package versions were bumped across the monorepo (11.46.0-alpha.5 → alpha.6) and NOTICE/module-federation dependencies updated. Functional changes add OIDC authentication support for Tiger data sources, remove several deprecated feature flags and their gated dashboard/export logic, delete the plugin widget overlay UI, and introduce a transfer-ownership permission gate in the object share dialog.

Changes

Release Version Bump

Layer / File(s) Summary
NOTICE and module-federation license bump
NOTICE
Generation date, revision ID, and module-federation package (error-codes, runtime, runtime-core, sdk) entries updated from 2.3.1 to 2.6.0.
Package version bump
libs/..., tools/..., examples/..., templates/..., common/config/rush/version-policies.json, libs/sdk-code-convertors/python/pyproject.toml
Package versions bumped from 11.46.0-alpha.5 to 11.46.0-alpha.6; sdk-ui-pluggable-host also bumps its @module-federation/runtime dependency to 2.6.0.

OIDC Authentication for Tiger Data Sources

Layer / File(s) Summary
Data source request contracts
libs/sdk-backend-tiger/api/sdk-backend-tiger.api.md, libs/sdk-backend-tiger/src/backend/tigerSpecificFunctions.ts, common/changes/.../nen-cq-2505_...json
Adds authenticationType to IDataSourcePatchRequest, IDataSourceTestConnectionRequest, and IDataSourceUpsertRequest.
Create/update/patch payloads and feature flag
libs/sdk-backend-tiger/src/backend/tigerSpecificFunctions.ts, libs/sdk-backend-tiger/src/backend/features/feature.ts, libs/sdk-backend-tiger/src/backend/uiFeatures.ts
Includes authenticationType in create/update/patch API calls and adds the EnableOidcAuth/enableOidcAuth feature flag.

Deprecated Feature Flag Removal

Layer / File(s) Summary
Flag type/enum removal
libs/sdk-backend-tiger/src/backend/{uiFeatures,features/feature}.ts, libs/sdk-model/src/settings/settings.ts, libs/sdk-model/api/sdk-model.api.md
Removes enableAthenaDataSource, enableCustomizedDashboardsWithoutPluginOverlay, enableCyclicalToDateFilters, enableNewPdfTabularExport, enableKDEmptyDateValuesFilter, enableImprovedRankingFilter.
Dashboard selector removal
libs/sdk-ui-dashboard/{api/sdk-ui-dashboard.api.md,src/index.ts,src/model/store/config/configSelectors.ts,src/model/store/widgetExports/widgetExportsSelectors.ts,src/model/store/executionResults/executionResultsSelectors.ts}
Removes deprecated selectors and their re-exports; updates PDF export eligibility logic.
Component gating updates
libs/sdk-ui-dashboard/src/_staging/dateFilterConfig/*, .../DefaultDashboardDateFilter.tsx, .../useInsightExport.ts, .../DrillDialog.tsx
Removes feature-flag gating from empty-values handling and PDF-export visibility logic.

Dashboard Widget Overlay Removal

Layer / File(s) Summary
Overlay controller and rendering removal
libs/sdk-ui-dashboard/src/presentation/flexibleLayout/DashboardItemOverlay/DashboardItemOverlayController.tsx, .../DashboardLayoutWidget.tsx, .../DefaultDashboardLayoutRenderer/DashboardLayoutSection.tsx, .../localization/bundles/en-US.json
Deletes the overlay controller and its rendering wiring, plus related localization strings.

Object Share Transfer Ownership Permission Gate

Layer / File(s) Summary
Controller types and API report
libs/sdk-ui-ext/src/share/objectShareController.types.ts, libs/sdk-ui-ext/api/sdk-ui-ext.api.md
Adds canTransferOwnership to controller state and isOpen to controller options.
useAccessList permission computation
libs/sdk-ui-ext/src/share/useAccessList.ts
Conditionally resolves current user while dialog is open and computes canTransferOwnership from EDIT grants.
Controller and dialog wiring
libs/sdk-ui-ext/src/share/useObjectShareController.ts, .../ObjectShareDialog.tsx, libs/sdk-ui-catalog/src/catalogDetail/share/CatalogItemShareProvider.tsx
Wires isOpen/canTransferOwnership through the controller and gates the transfer-ownership action.
Gating tests
libs/sdk-ui-ext/src/share/tests/*, libs/sdk-ui-catalog/src/catalogDetail/share/tests/CatalogItemShareProvider.test.tsx
Tests verify transfer-ownership visibility and profile-resolution timing based on canTransferOwnership/isOpen.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ObjectShareDialog
  participant useObjectShareController
  participant useAccessList
  participant Backend

  ObjectShareDialog->>useObjectShareController: isOpen=true, target
  useObjectShareController->>useAccessList: dialogOpen, onSaved
  useAccessList->>Backend: getCurrentUserRef() (only if dialogOpen)
  Backend-->>useAccessList: user profile (login)
  useAccessList->>useAccessList: compute canTransferOwnership from EDIT grant
  useAccessList-->>useObjectShareController: canTransferOwnership
  useObjectShareController-->>ObjectShareDialog: state.canTransferOwnership
  ObjectShareDialog->>ObjectShareDialog: wire onTransferOwnership only if canTransferOwnership
Loading

Poem

A hop, a skip, a version bump,
OIDC hops in with a Snowflake jump,
Old flags retired, overlays gone,
Ownership transfer now guarded and drawn,
This bunny thumps approval with glee! 🐇✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too brief and misses the repository’s required template and mandatory warning/exception text. Add the required description template content, including the PR restriction warning, the rel/9.9 exception, and the sync details.
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is related to the main change: an automated sync from gdc-ui/sdk at source hash 8167f3b.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yenkins-admin yenkins-admin merged commit 5662f22 into master Jul 9, 2026
15 of 16 checks passed
@yenkins-admin yenkins-admin deleted the sync-from-gdc-ui-28991015161 branch July 9, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync PR is created from gdc-ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants