feat(lint): flag unrecognized typography sub-properties#125
Open
rmyndharis wants to merge 1 commit into
Open
Conversation
A typography token's sub-properties outside the schema (fontFamily, fontSize, fontWeight, lineHeight, letterSpacing, fontFeature, fontVariation) were silently dropped by the model — never resolved, never exported, and with no diagnostic, so a typo like `fontwight` or an unsupported property like `textTransform` vanished without a trace. Emit a warning for each, mirroring how unknown component sub-tokens are already reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typography sub-properties outside the schema —
fontFamily,fontSize,fontWeight,lineHeight,letterSpacing,fontFeature,fontVariation— were silently dropped by the model: never resolved, never emitted to Tailwind/DTCG, and with no finding. A typo (fontwight) or an unsupported property (textTransform,color) simply vanished, looking identical to "the linter didn't notice."This mirrors the existing treatment of unknown component sub-tokens, which the
broken-refrule already reports as a warning ("'X' is not a recognized component sub-token").Change
parseTypographynow emits awarningfor each sub-property not in the schema, e.g.:Recognized properties resolve exactly as before. Warnings don't affect the exit code (only errors do), so this is additive.
Testing
bun test: 283 pass, 1 skip, 0 fail (added a test: an unknowntextTransformwarns attypography.<token>.textTransformwhilefontFamilystill resolves and never warns).bun run lint(tsc --noEmit): clean.