Skip to content

Performance improvements findAgentToRun method #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omarmahamid wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −5
Open

Performance improvements findAgentToRun method #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions core/src/main/java/com/google/adk/runner/Runner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
import io.reactivex.rxjava3.subjects.CompletableSubject;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Optional;
Expand Down Expand Up @@ -772,10 +771,9 @@ private boolean isTransferableAcrossAgentTree(BaseAgent agentToRun) {
* @return agent to run.
*/
private BaseAgent findAgentToRun(Session session, BaseAgent rootAgent) {
List<Event> events = new ArrayList<>(session.events());
Collections.reverse(events);

for (Event event : events) {
List<Event> events = session.events();
for (int i = events.size() - 1; i >= 0; i--) {
Event event = events.get(i);
String author = event.author();
if (author == null) {
continue;
Expand Down