Add a few more benchmarks distilled from a few slow examples - #1787
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add a few more benchmarks distilled from a few slow examples#1787copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
(a) One has lots of short-circuit conditions in ifs plus early returns
- this adds lots of constraints to the flow condition, though most
of the constraints may not actually be relevant to pointers
- the short-circuiting leads to lots of pairwise calls to joinFlowConditions
interleaving AND and OR (not as clean for buildCNF later)
(b) One has lots of member updates
- TBD why slow
(c) One has a large static array
- related to a FIXME for doing too much Env.fork()
PiperOrigin-RevId: 964996468
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few more benchmarks distilled from a few slow examples
(a) One has lots of short-circuit conditions in ifs plus early returns
of the constraints may not actually be relevant to pointers
interleaving AND and OR (not as clean for buildCNF later)
(b) One has lots of member updates
(c) One has a large static array