Fix declval issues in constructor member initializer list - #1807
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix declval issues in constructor member initializer list#1807copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_966766855
branch
from
August 18, 2026 20:45
17a3b58 to
c3e1f7c
Compare
This changes `BodyVisitor` to skip trying to evaluate expressions in contexts where the expression should never be evaluated, which lead to very strange indirect error messages as justifications for why Crubit couldn't bind to some things like constructors. You can see in the golden diff that the `Clone` impl correctly generates now. PiperOrigin-RevId: 966766855
copybara-service
Bot
force-pushed
the
test_966766855
branch
from
August 19, 2026 00:22
c3e1f7c to
edfa199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix declval issues in constructor member initializer list
This changes
BodyVisitorto skip trying to evaluate expressions in contexts where the expression should never be evaluated, which lead to very strange indirect error messages as justifications for why Crubit couldn't bind to some things like constructors.You can see in the golden diff that the
Cloneimpl correctly generates now.