chore: refactor setting of auto-populated field in request#17004
Open
parthea wants to merge 9 commits into
Open
chore: refactor setting of auto-populated field in request#17004parthea wants to merge 9 commits into
parthea wants to merge 9 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the auto-population of UUID4 fields by centralizing the logic into a new _setup_request_id static method within the generated clients and updating shared macros to utilize it. Feedback indicates that the current implementation of _setup_request_id lacks proper support for dictionary and pure protobuf message types, which will lead to runtime errors. Additionally, the Jinja template condition for generating this method is incorrectly defined, causing it to be included as dead code even when no fields require auto-population.
parthea
force-pushed
the
refactor-autopopulated-fields
branch
from
f2f692b to
0223a0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #16944. Please review #16944 first.
This PR addresses the feedback in #16944 (comment)