gnd(deploy): Add prompt for missing --version-label#6532
Merged
dimitrovmaksim merged 1 commit intomasterfrom Apr 22, 2026
Merged
gnd(deploy): Add prompt for missing --version-label#6532dimitrovmaksim merged 1 commit intomasterfrom
dimitrovmaksim merged 1 commit intomasterfrom
Conversation
…de. Require the flag in non-interactive. Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
dimitrovmaksim
force-pushed
the
gnd/deploy-version-label-prompt
branch
from
25b8f9a to
68bb8ac
Compare
lutter
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves
gnd deploybehavior when--version-labelis omitted:Design choices:
Prompt uses
CustomType<String>instead ofText. The reason is the raw value needs to be normalized and then validated.Textdoes not expose a custom parser, so validation happens aginst the raw value, which means we need to normalize the value twice, or add a custom validation/loop to re-prompt on invalid values.Version label is not semver-validated (same as graph-cli).