Remove JSR-305 ThreadSafe annotation and replace with JavaDoc#12762
Open
Kainsin wants to merge 2 commits intogrpc:masterfrom
Open
Remove JSR-305 ThreadSafe annotation and replace with JavaDoc#12762Kainsin wants to merge 2 commits intogrpc:masterfrom
Kainsin wants to merge 2 commits intogrpc:masterfrom
Conversation
Contributor
Author
|
I am not sure why that test is failing - it's passing locally. Am I missing a configuration setting that is causing an extra log to be emitted here? |
This fixes a potential race condition where a test runs a thread in the executor that does some logging. Without waiting for threads to finish, another test can be run while that background thread is still executing. This can cause flaky issues with tests that only think that their test code is executing.
Contributor
Author
|
I was able to make a change to fix the test - it's in the second commit. @kannanjgithub you reviewed my last PR for this, would you be able to review this one as well? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt to remove JSR-305 annotations but instead of replacing with ErrorProne's ThreadSafe, sticks to adding a JavaDoc comment. This should basically keep things inline with what JSR-305 ThreadSafe affords.
Adding ErrorProne's ThreadSafe can be considered in the future, as it expects more things than JSR-305.
Removing the JSR-305 dependency here allows Java applications that have moved away from javax to compile and avoids a bug in Immutables and Lombok (and possibly other annotation processors) from failing when JSR-305 is not present.