Conversation
jdcormie
force-pushed
the
grpc-binder-jacoco
branch
from
e2dacf5 to
47f8e75
Compare
jdcormie
force-pushed
the
grpc-binder-jacoco
branch
from
47f8e75 to
1255bd2
Compare
jdcormie
changed the title
| dependsOn "testDebugUnitTest" | ||
|
|
||
| reports { | ||
| // For codecov.io and coveralls. |
There was a problem hiding this comment.
You might want to tweak this comment.
I think coveralls can only handle one report, so we use grpc-all for that. So this report configuration should never matter for coveralls. And right now we are excluding android from it, which is appropriate because we're uploading with Java 8 (which we can't build Android at all) and we aren't building android at all in those github actions.
For codecov.io, I think this would actually be useful, if we actually ran the build/tests for binder on github actions.
There was a problem hiding this comment.
Thanks. My goal was, and still is, to have increases/decreases in coverage reported by the github action. But when I noticed the grpc-all aspect the -PskipAndroid issue I backed off to just what you see in this PR. I didn't realize there's also a Java 8 issue :(.
Anyway, this comment is just about the enable xml line that follows -- IIUC tools like codecov and coveralls consume the xml version of the report which is off by default. LMK if you feel strongly about tweaking it.
Can you think of an easy way to make binder/... coverage reports available to PR reviewers? Maybe it could be a new/different report or action?
2 participants
No description provided.